Adding info logging to display the hashed encryptionKey & adding test… #139874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc13greiner
added
Team:Security
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
|
Pinging @elastic/kibana-security (Team:Security) |
azasypkin
added
release_note:enhancement
and removed
release_note:feature
jeramysoucy
reviewed
Sep 8, 2022
| .update(config.encryptionKey) | ||
| .digest('base64'); | ||
|
|
||
| this.logger.info(`Hashed 'encryptionKey' for this instance: ${hashedEncryptionKey}`); |
There was a problem hiding this comment.
Just a nit/question - do we want to refer to the yml field path (xpack.encryptedSavedObjects.encryptionKey) just for clarity of where the setting is located?
There was a problem hiding this comment.
++ you can technically figure this out by reading which plugin wrote the log message, but I think spelling out the entire path would be easier to parse (and search for in logs!)
There was a problem hiding this comment.
Good call! Added in latest commit!
jeramysoucy
approved these changes
Sep 8, 2022
@jeramysoucy maybe this is something we could add to Discussions for the weekly sync? |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kc13greiner
added
backport:prev-major
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 12, 2022
elastic#139874) * Adding info logging to display the hashed encryptionKey & adding test cases * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fixing test logger * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Adding config path for message * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b474a45)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 12, 2022
#139874) (#140532) * Adding info logging to display the hashed encryptionKey & adding test cases * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fixing test logger * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Adding config path for message * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b474a45) Co-authored-by: Kurt <kc13greiner@users.noreply.github.com>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kc13greiner
added a commit
to kc13greiner/kibana
that referenced
this pull request
Sep 14, 2022
elastic#139874) * Adding info logging to display the hashed encryptionKey & adding test cases * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fixing test logger * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Adding config path for message * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b474a45) # Conflicts: # x-pack/plugins/encrypted_saved_objects/server/plugin.test.ts
kc13greiner
added a commit
that referenced
this pull request
Sep 19, 2022
…ng test… (#139874) (#140759) * Adding info logging to display the hashed encryptionKey & adding test… (#139874) * Adding info logging to display the hashed encryptionKey & adding test cases * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fixing test logger * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Adding config path for message * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b474a45) # Conflicts: # x-pack/plugins/encrypted_saved_objects/server/plugin.test.ts * Fixing type issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… cases
Summary
Adding logging to display a hashed value of the supplied encryptionKey
Release Notes
Debugging - Hashed encryption key now logged on Kibana start-up to help users solve conflicting encryptionKey configurations