Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates vis_controller from mountReactNode to toMountPoint #137636

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Migrates vis_controller from mountReactNode to toMountPoint #137636

merged 2 commits into from
Aug 1, 2022

Conversation

TinaHeiligers
Copy link
Contributor

Summary

Part of #137614

Core's mount utils are not intended for public consumption.
This PR changes the vis_controller's implementation accordingly.

@TinaHeiligers TinaHeiligers added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.5.0 labels Jul 29, 2022
@TinaHeiligers TinaHeiligers marked this pull request as ready for review July 29, 2022 22:48
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner July 29, 2022 22:48
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVislib 348.8KB 348.8KB -3.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVislib 15.7KB 15.6KB -139.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine, LGTM

@TinaHeiligers TinaHeiligers merged commit a8ebf5a into elastic:main Aug 1, 2022
@TinaHeiligers TinaHeiligers deleted the migrate-vis-controller-mountReactNode-to-toMountPoint branch August 1, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TinaHeiligers @kibana-ci @stratoula @kibanamachine