Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Framework] Improve generator snippets (#13598) #13599

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

cjcenizal
Copy link
Contributor

Cherry-picked from #13598

* Remove extraneous path info from SCSS import snippet.
* Add GuideCode to demo page. Put stateless function params on multiple lines.
* Log an error if you try to create a component with a blank name.
@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.1.0 v7.0.0 labels Aug 18, 2017
@cjcenizal cjcenizal merged commit cb5f508 into elastic:master Aug 18, 2017
@cjcenizal cjcenizal deleted the generator-template-cleanup branch August 18, 2017 23:12
@cjcenizal cjcenizal changed the title [UI Framework] [K7] Improve generator snippets (#13598) [UI Framework] Improve generator snippets (#13598) Aug 18, 2017
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 18, 2017
…ic#13599)

* Remove extraneous path info from SCSS import snippet.
* Add GuideCode to demo page. Put stateless function params on multiple lines.
* Log an error if you try to create a component with a blank name.
cjcenizal added a commit that referenced this pull request Aug 18, 2017
)

* Remove extraneous path info from SCSS import snippet.
* Add GuideCode to demo page. Put stateless function params on multiple lines.
* Log an error if you try to create a component with a blank name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.1.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant