Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Framework] KuiCheckbox and KuiSwitch visual bugs #13515

Merged
merged 3 commits into from
Aug 15, 2017
Merged

[UI Framework] KuiCheckbox and KuiSwitch visual bugs #13515

merged 3 commits into from
Aug 15, 2017

Conversation

cjcenizal
Copy link
Contributor

This was bugging me with KuiSwitch... there's a double border where the icon and body overlap.

Before:

image

After:

image

@cjcenizal cjcenizal added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Aug 15, 2017
@cjcenizal cjcenizal requested a review from snide August 15, 2017 18:54
snide
snide approved these changes Aug 15, 2017
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjcenizal cjcenizal merged commit ea1bd9a into elastic:k7-ui-framework Aug 15, 2017
@cjcenizal cjcenizal deleted the k7/checkbox-switch-states branch August 15, 2017 20:10
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 16, 2017
@cjcenizal
[UI Framework] KuiCheckbox and KuiSwitch visual bugs (elastic#13515)
339470a 
* Retain focus state appearance on KuiCheckbox when it's being clicked on.
* Document KuiIcon check and lock types.
* Use KuiIcon inside of KuiSwitch to remove aliased border.
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 26, 2017
@cjcenizal
[UI Framework] KuiCheckbox and KuiSwitch visual bugs (elastic#13515)
ddc69a6 
* Retain focus state appearance on KuiCheckbox when it's being clicked on.
* Document KuiIcon check and lock types.
* Use KuiIcon inside of KuiSwitch to remove aliased border.
cjcenizal added a commit that referenced this pull request Sep 19, 2017
@cjcenizal
[UI Framework] KuiCheckbox and KuiSwitch visual bugs (#13515)
ad61a00 
* Retain focus state appearance on KuiCheckbox when it's being clicked on.
* Document KuiIcon check and lock types.
* Use KuiIcon inside of KuiSwitch to remove aliased border.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcenizal @snide