Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use isSearchStored param instead of server-side checkId #135036

Merged
merged 5 commits into from
Jul 11, 2022
Merged

use isSearchStored param instead of server-side checkId #135036

merged 5 commits into from
Jul 11, 2022

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jun 23, 2022 •
edited
Loading

Summary

Instead of server-side checking if the search has already been stored in search session on each poll, we will use client side state to set a new isSearchStored as part of a search poll

@Dosant Dosant requested a review from lukasolson June 23, 2022 15:01
@Dosant Dosant changed the title use client side param instead of server checkId use isSearchStored param instead of server-side checkId Jun 23, 2022
@Dosant Dosant mentioned this pull request Jun 23, 2022
Merged
84 tasks
@Dosant
Copy link
Contributor Author

Dosant commented Jul 6, 2022

@elasticmachine merge upstream

@Dosant Dosant marked this pull request as ready for review July 6, 2022 15:31
@Dosant Dosant requested a review from a team as a code owner July 6, 2022 15:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

lukasolson
lukasolson approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

@Dosant
Copy link
Contributor Author

Dosant commented Jul 11, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inspector 15.9KB 16.0KB +55.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 420.9KB 421.5KB +557.0B
Unknown metric groups

API count

id before after diff
data 3077 3080 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit a985fb9 into elastic:search-sessions-stabilization-stage-1 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasolson lukasolson lukasolson approved these changes

Assignees
No one assigned
Labels
Feature:Search Sessions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dosant @elasticmachine @kibana-ci @lukasolson @kibanamachine