Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited the external plugin demo documentation #134748

Merged
merged 3 commits into from Jul 19, 2022
Merged

Edited the external plugin demo documentation #134748

merged 3 commits into from Jul 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2022

Summary

This is for issue #123217
Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@jportner jportner requested a review from a team June 20, 2022 13:30
@gchaps
Copy link
Contributor

gchaps commented Jun 30, 2022

@elasticmachine merge upstream

@gchaps gchaps added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jun 30, 2022
@afharo
Copy link
Member

afharo commented Jul 19, 2022

@elasticmachine merge upstream

@afharo
Copy link
Member

afharo commented Jul 19, 2022

@elasticmachine run elasticsearch-ci/docs

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@najmiehsa thank you for your contribution! LGTM! 🧡

@afharo afharo enabled auto-merge (squash) July 19, 2022 08:02
@afharo afharo added backport:skip This commit does not require backporting backport:all-open Backport to all branches that could still receive a release and removed backport:skip This commit does not require backporting labels Jul 19, 2022
@suchcodemuchwow
Copy link
Contributor

buildkite test this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 8f87df1 into elastic:main Jul 19, 2022
@ghost
Copy link
Author

ghost commented Jul 19, 2022

Thank you ^^

@ghost ghost deleted the Pdemo branch July 19, 2022 13:05
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 19, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8f87df1)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 19, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8f87df1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
7.17
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 19, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8f87df1)

Co-authored-by: Najmieh Sadat <98463228+najmiehsa@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 19, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8f87df1)

Co-authored-by: Najmieh Sadat <98463228+najmiehsa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.17.6 v8.3.3 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants