-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix share to space flyout sizing #133949
Merged
Merged
Fix share to space flyout sizing #133949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-security (Team:Security) |
watson
approved these changes
Jun 9, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Jun 9, 2022
(cherry picked from commit 17c2500)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 9, 2022
JFR: Switched |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:Security/Sharing Saved Objects
Platform Security - Sharing Saved Objects feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Security
Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
v8.3.0
v8.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In #128946 I fixed some UX problems in the "Share to space" flyout (formerly "Assign to space" flyout). Those changes made it more resilient when rendered on smaller and larger screens.
However, there are three situations where a warning callout can be displayed at the top of the flyout:
Today I noticed that, due to my recent changes, these callouts were unintentionally stretching vertically when the viewport is tall. This PR fixes that so they don't stretch anymore.
Release note
Fixed minor UI sizing problems when attempting to share saved objects.
Screenshots before
Scenario 1
Scenario 2
Scenario 3 (using stub data, no actual aliases)
Screenshots after
Scenario 1
Scenario 2
Scenario 3 (using stub data, no actual aliases)