Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share to space flyout sizing #133949

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Jun 8, 2022

Overview

In #128946 I fixed some UX problems in the "Share to space" flyout (formerly "Assign to space" flyout). Those changes made it more resilient when rendered on smaller and larger screens.

However, there are three situations where a warning callout can be displayed at the top of the flyout:

  1. If an object has not yet been shared anywhere
  2. If an object is shared to All Spaces and the user doesn't have privileges to change that
  3. If one or more destination spaces have legacy URL alias conflicts

Today I noticed that, due to my recent changes, these callouts were unintentionally stretching vertically when the viewport is tall. This PR fixes that so they don't stretch anymore.

Release note

Fixed minor UI sizing problems when attempting to share saved objects.

Screenshots before

Scenario 1

image

Scenario 2

image

Scenario 3 (using stub data, no actual aliases)

image

Screenshots after

Scenario 1

image

Scenario 2

image

Scenario 3 (using stub data, no actual aliases)

image

@jportner jportner added release_note:fix Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! auto-backport Deprecated - use backport:version if exact versions are needed Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature v8.3.0 v8.4.0 v8.2.3 labels Jun 8, 2022
@jportner jportner requested a review from a team as a code owner June 8, 2022 19:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 152.9KB 153.0KB +53.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner removed the v8.2.3 label Jun 8, 2022
@jportner jportner enabled auto-merge (squash) June 8, 2022 23:04
@jportner jportner merged commit 17c2500 into elastic:main Jun 9, 2022
kibanamachine pushed a commit that referenced this pull request Jun 9, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 9, 2022
(cherry picked from commit 17c2500)

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
@azasypkin azasypkin added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Jun 22, 2022
@azasypkin
Copy link
Member

JFR: Switched release_note:fix label to release_note:skip as the EUI regression that caused this issue has never been released.

@jportner jportner deleted the fix-share-flyout-size branch June 22, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants