Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup test/functional/fixtures/es_archiver/dashboard/legacy #133827

Merged
merged 6 commits into from
Jun 8, 2022
Merged

cleanup test/functional/fixtures/es_archiver/dashboard/legacy #133827

merged 6 commits into from
Jun 8, 2022

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Jun 7, 2022 •
edited
Loading

Summary

This PR removes the es_archive at test/functional/fixtures/es_archiver/dashboard/legacy and fixes dashboard.initTest() to use the renamed kbn_archive test/functional/fixtures/kbn_archiver/dashboard/legacy/legacy.json

@LeeDr LeeDr mentioned this pull request Jun 7, 2022
Closed
@LeeDr
Copy link
Author

LeeDr commented Jun 8, 2022

@elasticmachine merge upstream

@LeeDr
Copy link
Author

LeeDr commented Jun 8, 2022

@elasticmachine merge upstream

@LeeDr LeeDr changed the title kbnArchiver es_archiver/dashboard/legacy cleanup test/functional/fixtures/es_archiver/dashboard/legacy Jun 8, 2022
@LeeDr LeeDr added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas test_ui_functional release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.4.0 labels Jun 8, 2022
@LeeDr LeeDr marked this pull request as ready for review June 8, 2022 20:20
@LeeDr LeeDr requested a review from a team as a code owner June 8, 2022 20:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson
ThomThomson approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! Changes LGTM and it's especially nice that we don't need the conditional statement to use esArchiver for non-CCS testing anymore.

cuff-links
cuff-links approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@LeeDr LeeDr merged commit e02024b into elastic:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuff-links cuff-links cuff-links approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas test_ui_functional v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LeeDr @elasticmachine @kibana-ci @cuff-links @ThomThomson @kibanamachine