[Exploratory View] Re-introduce required id types for FormatType
#133812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
shahzad31
approved these changes
Jun 7, 2022
⚪ Backport skippedThe pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
justinkambic
deleted the
expl-view-reintroduce-format-type-id-requirements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently, a change removed the opinionated
idtype from one of Exploratory View's types. This change reintroduces that type requirement. The reasoning is that DX will be nicer because TypeScript will force the user to choose valid id types and give them the selection via Intellisense.