Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Load locations only once #133564

Merged
merged 2 commits into from
Jun 8, 2022
Merged

[Synthetics] Load locations only once #133564

merged 2 commits into from
Jun 8, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 3, 2022 •
edited
Loading

Summary

Load service locations only once, it also fixes an issue, where if locations weren't defined in manifest, will stop infite loading of the page.

@shahzad31 shahzad31 changed the title load locations once [Synthetics] Load locations only once Jun 8, 2022
@shahzad31 shahzad31 marked this pull request as ready for review June 8, 2022 09:29
@shahzad31 shahzad31 requested a review from a team as a code owner June 8, 2022 09:29
@shahzad31 shahzad31 self-assigned this Jun 8, 2022
@shahzad31 shahzad31 added v8.4.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 8, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #43 / dashboard elements dashboard elements Controls Dashboard options list integration Interactions between options list and dashboard "after all" hook in "Interactions between options list and dashboard"
  • [job] [logs] FTR Configs #43 / dashboard elements dashboard elements Controls Dashboard options list integration Interactions between options list and dashboard Options List dashboard no validation Does not mark multiple selections invalid with Filter

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 858.1KB 858.2KB +104.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

awahab07
awahab07 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit fe44001 into elastic:main Jun 8, 2022
@shahzad31 shahzad31 deleted the fix-empty-locations-reload branch June 8, 2022 11:25
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 8, 2022
@LeeDr LeeDr added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees

@shahzad31 shahzad31

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shahzad31 @kibana-ci @elasticmachine @awahab07 @LeeDr @kibanamachine