Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump history to v5.0.1 #132683

Closed

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented May 23, 2022

Summary

Fix #132600

Attempt to bump history to v5+

Main problem is that history and react-router are tightly coupled, and that react-router don't have up-to-date types. history now ships its own types starting in 5.0.0, however react-router doesn't, and the lastest version of its types (5.1.18) is still referencing history 4.x types, with a lot of incompatibilities.

I tried to bump history directly to 5.3.0, however there was a lot of problems. Some types are renamed, split, and Location and History are no longer generic.

So I then tried to use history 5.0.1, which is the last version where the generic location and history are still present in. There are still type renames to handle, but maybe we can get to some okay state here.

@pgayvallet pgayvallet force-pushed the kbn-132600-bump-history-to-v5 branch from 6ecc4b0 to 690f7e0 Compare May 23, 2022 14:16
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 23, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: metrics for 690f7e0 were not reported

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update history to >=5.0 and to allow transaction retry
3 participants