Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #132600
Attempt to bump history to
v5+
Main problem is that
history
andreact-router
are tightly coupled, and thatreact-router
don't have up-to-date types.history
now ships its own types starting in5.0.0
, howeverreact-router
doesn't, and the lastest version of its types (5.1.18
) is still referencing history4.x
types, with a lot of incompatibilities.I tried to bump history directly to
5.3.0
, however there was a lot of problems. Some types are renamed, split, andLocation
andHistory
are no longer generic.So I then tried to use history
5.0.1
, which is the last version where the generic location and history are still present in. There are still type renames to handle, but maybe we can get to some okay state here.