Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing management app docs links #130776

Merged
merged 2 commits into from
Apr 21, 2022
Merged

[ML] Fixing management app docs links #130776

merged 2 commits into from
Apr 21, 2022

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Apr 21, 2022 •
edited
Loading

Fixes #130706

Breadcrumb changed to Machine Learning
image

Trained model docs link updated, now points to https://www.elastic.co/guide/en/machine-learning/master/ml-trained-models.html

image

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience release_note:fix backport pending :ml Feature:3rd Party Models ML 3rd party models v8.3.0 v8.2.1 labels Apr 21, 2022
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 21, 2022 09:49
@jgowdyelastic jgowdyelastic self-assigned this Apr 21, 2022
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 21, 2022 09:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, but otherwise tested and LGTM

x-pack/plugins/ml/public/application/management/breadcrumbs.ts Outdated Show resolved Hide resolved
lcawl
lcawl approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.3MB 3.3MB +215.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 320.4KB 320.5KB +74.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 5fe9437 into elastic:main Apr 21, 2022
@jgowdyelastic jgowdyelastic deleted the fix-management-app-doc-links branch April 21, 2022 21:03
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 130776 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 25, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 130776 or prevent reminders by adding the backport:skip label.

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 130776 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 130776 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 130776 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 130776 or prevent reminders by adding the backport:skip label.

lcawl pushed a commit to lcawl/kibana that referenced this pull request May 3, 2022
@jgowdyelastic @lcawl
[ML] Fixing management app docs links (elastic#130776)
001dc06 
* [ML] Fixing management app docs links

* changing translation id

(cherry picked from commit 5fe9437)
@lcawl lcawl mentioned this pull request May 3, 2022
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

lcawl added a commit that referenced this pull request May 3, 2022
@lcawl @jgowdyelastic
[ML] Fixing management app docs links (#130776) (#131460)
dfc5bf7 
* [ML] Fixing management app docs links

* changing translation id

(cherry picked from commit 5fe9437)

Co-authored-by: James Gowdy <jgowdy@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 3, 2022
@jgowdyelastic jgowdyelastic added auto-backport Deprecated - use backport:version if exact versions are needed and removed backport pending labels May 4, 2022
@kibanamachine
Copy link
Contributor

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 130776

Questions ?

Please refer to the Backport tool documentation

jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request May 4, 2022
@jgowdyelastic
[ML] Fixing management app docs links (elastic#130776)
5cca489 
* [ML] Fixing management app docs links

* changing translation id

(cherry picked from commit 5fe9437)

# Conflicts:
#	x-pack/plugins/ml/public/application/management/jobs_list/components/jobs_list_page/jobs_list_page.tsx
@jgowdyelastic jgowdyelastic mentioned this pull request May 4, 2022
Merged
@jgowdyelastic jgowdyelastic removed the auto-backport Deprecated - use backport:version if exact versions are needed label May 4, 2022
jgowdyelastic added a commit that referenced this pull request May 4, 2022
@jgowdyelastic
[ML] Fixing management app docs links (#130776) (#131483)
0901e00 
* [ML] Fixing management app docs links

* changing translation id

(cherry picked from commit 5fe9437)

# Conflicts:
#	x-pack/plugins/ml/public/application/management/jobs_list/components/jobs_list_page/jobs_list_page.tsx
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@jgowdyelastic @kertal
[ML] Fixing management app docs links (elastic#130776)
f3389b6 
* [ML] Fixing management app docs links

* changing translation id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@lcawl lcawl lcawl approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:3rd Party Models ML 3rd party models :ml release_note:fix v8.2.1 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Label and link issues in Stack Management > Machine Learning
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @peteharverson @lcawl