Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K7] Add Typography components #13048

Merged
merged 12 commits into from
Jul 24, 2017

Conversation

cjcenizal
Copy link
Contributor

No description provided.

@cjcenizal cjcenizal added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Jul 22, 2017
@cjcenizal cjcenizal requested a review from snide July 22, 2017 00:10
@cjcenizal cjcenizal force-pushed the k7/typography-components branch from 370e4ef to 290c1ea Compare July 22, 2017 00:12
@cjcenizal cjcenizal mentioned this pull request Jul 22, 2017
51 tasks
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

The title classes are all actually $kuiFullShade (black) which gives them some small contrast against default text.

Object title is not italic. If italics are used, it would be discretionary and I'd expect to apply that through a generic <em> wrapper or a utility class.

Although you took these names from the design (sorry), I'd go instead with kuiTitle, kuiTitle--large, kuiTitle--small so they are less genetically tied to function. This also follows closer with the patterns we're establishing of tshirt sizing everything.

I'd also make classes for the following to cover all typography used.

  1. utility classes for size based on the partials/mixins that were made (kui--fontSizeSmall...etc).
  2. utility classes for color (kui--textSubdued). Should be utility because you want it to be applied to anything, regardless of origin component.
  3. A code/mono utility using Roboto Mono.

@cjcenizal
Copy link
Contributor Author

@snide Ready for your 👀 again!

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, should be kuiTitleSmall to fit with conventions we're using. Sizing is always on the end in our current stuff. We should prolly add this kind of namespacing pattern to our styleguide.

@cjcenizal cjcenizal force-pushed the k7/typography-components branch from 7e3a354 to a6b821c Compare July 24, 2017 19:59
@cjcenizal
Copy link
Contributor Author

@snide Can we create an exception to that rule when we're building components? Going off the idea that we should use the same language when discussing a component in Sketch, CSS, React, and in the browser, I'd like to keep the names as close to natural language as possible. Which would mean adjectives first and nouns last, e.g. "Modal header", "Large title". This should make it easier to discuss, think about, and find components.

@cjcenizal cjcenizal force-pushed the k7/typography-components branch from a6b821c to 18cc84c Compare July 24, 2017 22:00
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed offline and decided to make these modifiers.

@cjcenizal cjcenizal merged commit 411cbac into elastic:k7-ui-framework Jul 24, 2017
@cjcenizal cjcenizal deleted the k7/typography-components branch July 24, 2017 22:36
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 16, 2017
* Add Typography documentation. Add Title and Text components.
* Switch from Ubuntu Mono to Roboto Mono. Add codeFont utility.
* Add subduedText utility.
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 26, 2017
* Add Typography documentation. Add Title and Text components.
* Switch from Ubuntu Mono to Roboto Mono. Add codeFont utility.
* Add subduedText utility.
cjcenizal added a commit that referenced this pull request Sep 19, 2017
* Add Typography documentation. Add Title and Text components.
* Switch from Ubuntu Mono to Roboto Mono. Add codeFont utility.
* Add subduedText utility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants