-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K7] Add Typography components #13048
[K7] Add Typography components #13048
Conversation
370e4ef
to
290c1ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
The title classes are all actually $kuiFullShade
(black) which gives them some small contrast against default text.
Object title is not italic. If italics are used, it would be discretionary and I'd expect to apply that through a generic <em>
wrapper or a utility class.
Although you took these names from the design (sorry), I'd go instead with kuiTitle, kuiTitle--large, kuiTitle--small
so they are less genetically tied to function. This also follows closer with the patterns we're establishing of tshirt sizing everything.
I'd also make classes for the following to cover all typography used.
- utility classes for size based on the partials/mixins that were made (kui--fontSizeSmall...etc).
- utility classes for color (kui--textSubdued). Should be utility because you want it to be applied to anything, regardless of origin component.
- A code/mono utility using Roboto Mono.
@snide Ready for your 👀 again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, should be kuiTitleSmall
to fit with conventions we're using. Sizing is always on the end in our current stuff. We should prolly add this kind of namespacing pattern to our styleguide.
7e3a354
to
a6b821c
Compare
@snide Can we create an exception to that rule when we're building components? Going off the idea that we should use the same language when discussing a component in Sketch, CSS, React, and in the browser, I'd like to keep the names as close to natural language as possible. Which would mean adjectives first and nouns last, e.g. "Modal header", "Large title". This should make it easier to discuss, think about, and find components. |
a6b821c
to
18cc84c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed offline and decided to make these modifiers.
* Add Typography documentation. Add Title and Text components. * Switch from Ubuntu Mono to Roboto Mono. Add codeFont utility. * Add subduedText utility.
* Add Typography documentation. Add Title and Text components. * Switch from Ubuntu Mono to Roboto Mono. Add codeFont utility. * Add subduedText utility.
* Add Typography documentation. Add Title and Text components. * Switch from Ubuntu Mono to Roboto Mono. Add codeFont utility. * Add subduedText utility.
No description provided.