chore(NA): downgrades rules nodejs into v4.7.0 #130347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
LGTM, yarn kbn reset && yarn kbn bootstrap with a populated remote cache took 64 seconds.
info [bazel] INFO: Elapsed time: 64.299s, Critical Path: 8.51s
info [bazel] INFO: 945 processes: 658 remote cache hit, 280 internal, 7 darwin-sandbox.
info [bazel] INFO: Streaming build results to: https://app.buildbuddy.io/invocation/a5358f3e-22ff-492e-9f79-4bb33c1ae960
60mb downloaded, pretty reasonable (a couple cache misses on ARM macs are expected, but not causing any issues right now).
mistic
added
chore
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Apr 15, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Apr 15, 2022
* chore(NA): downgrade rules nodejs into v4.0.0 * chore(NA): include windows patch * chore(NA): polish downgrade code * chore(NA): include yarn.lock (cherry picked from commit 0b2da10)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 15, 2022
* chore(NA): downgrade rules nodejs into v4.0.0 * chore(NA): include windows patch * chore(NA): polish downgrade code * chore(NA): include yarn.lock (cherry picked from commit 0b2da10) Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
|
For awareness, we've had to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts what was done at #129522 , #130051 and #130214 as we found a major performance decreasing when building without no cache.