Restrict ES data proxy to msearch and search #13020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epixa
commented
Jul 21, 2017
| @@ -26,15 +26,15 @@ describe('formatMsg', function () { | |||
| data: { | |||
| statusCode: 403, | |||
| error: 'Forbidden', | |||
| message: '[security_exception] action [indices:data/read/mget] is unauthorized for user [user]' | |||
| message: '[security_exception] action [indices:data/read/msearch] is unauthorized for user [user]' | |||
There was a problem hiding this comment.
These references didn't have to be updated, but I wanted to remove all possible references to mget from client-side code to make future grepping a little easier.
We are only using msearch and search on this proxy, so there's no reason for us to expose more capabilities than this. Ultimately we want to move all functionality like this to REST API rather than being a straight up proxy, so this will help proxy usage not expand throughout upcoming versions until it can be removed entirely.
jbudz
approved these changes
Jul 21, 2017
|
Doesn't have to be part of this PR, but does this mean we could get rid of the DocSourceProvider including the data strategy? |
|
@tylersmalley I'm almost positive we can, but I wanted to run through it with Spencer to be certain |
|
That works for me @epixa, without mget that provider will error out so it might be worth going back and cleaning up the code. |
jimgoodwin
added
the
Team:Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are only using msearch and search on this proxy, so there's no reason
for us to expose more capabilities than this. Ultimately we want to move
all functionality like this to REST API rather than being a straight up
proxy, so this will help proxy usage not expand throughout upcoming
versions until it can be removed entirely.