Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Make add agent step styling more consistent #130198

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

jen-huang
Copy link
Contributor

Summary

While testing the add agent instructions redesign I noticed that the look of the steps is a little bit inconsistent, sometimes they are colored in (undefined/default look) and sometimes they are not (incomplete status). Per designs, I replaced instances of incomplete with either the default or disabled styling.

Example of disabled steps when no policy has been chosen yet:
image

Example of disabled confirm data step:
image

@jen-huang jen-huang added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 labels Apr 13, 2022
@jen-huang jen-huang self-assigned this Apr 13, 2022
@jen-huang jen-huang requested a review from a team as a code owner April 13, 2022 21:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang jen-huang changed the title [Fleet] Make add agent step statuses more consistent [Fleet] Make add agent step styling more consistent Apr 13, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 693.0KB 693.1KB +170.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jen-huang jen-huang merged commit 19ed205 into elastic:main Apr 14, 2022
@jen-huang jen-huang deleted the fix/instruction-step-statuses branch April 14, 2022 16:00
kibanamachine pushed a commit that referenced this pull request Apr 14, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 14, 2022
(cherry picked from commit 19ed205)

Co-authored-by: Jen Huang <jen.huang@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants