Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Telemetry: Update host filter list for detection rules #130095

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

pjhampton
Copy link
Contributor

Summary

Issue backref'd from a private repo.

Test of this new telemetry found that host filterlist was too permissive bringing back IP and Mac addresses. This is a 8.2 feature that has yet to be released. This PR lines up the host filterlist with the endpoint alerts.

This functionality is already covered with tests in https://github.com/elastic/kibana/blob/3877763e118b9e20b88eb9f89eb083d4581679fc/x-pack/plugins/security_solution/server/lib/telemetry/filterlists/index.test.ts

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@pjhampton pjhampton added Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.2.1 labels Apr 13, 2022
@pjhampton pjhampton requested a review from a team as a code owner April 13, 2022 09:49
@pjhampton pjhampton self-assigned this Apr 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@pjhampton pjhampton changed the title Update host filter list Security Telemetry: Update host filter list for detection rules Apr 13, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Security Solution Tests / Timeline search and filters Update kqlMode for timeline "before all" hook for "should be able to update timeline kqlMode with filter"

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pjhampton

Copy link
Contributor

@donaherc donaherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjhampton pjhampton merged commit 9c8440a into main Apr 14, 2022
@pjhampton pjhampton deleted the pjhampton/update-drule-host-filterlist branch April 14, 2022 15:27
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 130095

Questions ?

Please refer to the Backport tool documentation

@donaherc
Copy link
Contributor

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 18, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 130095 or prevent reminders by adding the backport:skip label.

@pjhampton pjhampton added auto-backport Deprecated - use backport:version if exact versions are needed and removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 19, 2022
kibanamachine pushed a commit that referenced this pull request Apr 19, 2022
(cherry picked from commit 9c8440a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 19, 2022
(cherry picked from commit 9c8440a)

Co-authored-by: Pete Hampton <pjhampton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0 v8.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants