-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Discover Classic View Filter In/Out placement when truncate:maxHeight
is set to 0
#129942
Conversation
@@ -286,5 +286,6 @@ export const getUiSettings: (docLinks: DocLinksServiceSetup) => Record<string, U | |||
'The maximum height that a cell in a table should occupy. Set to 0 to disable truncation.', | |||
}), | |||
schema: schema.number({ min: 0 }), | |||
requiresPageReload: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it! Tested in different browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on cloud deployment; worked as described.
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @kertal |
truncate:maxHeight
is set to 0
Summary
Fixes #128080
When setting
truncate:maxHeight
to0
in Advanced settings, CSS for truncating height of Classic table was no longer injected in global CSS.This led to an issue with the positioning of the filter buttons. It looked like this
This PR takes care of injecting CSS also for the
0
case, so the positioning of the filter buttons works correctly:What's more, since it takes a refresh of the browser page for the change of the
truncate:maxHeight
to take effect, there's now a toast displayed when users persisted the changeSteps to test:
doc_table:legacy
toOn
.truncate:maxHeight
to0
Checklist
Delete any items that are not applicable to this PR.