Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service environment should be selected when you edit the agent configuration #129929

Merged
merged 3 commits into from
Apr 12, 2022
Merged

[APM] Service environment should be selected when you edit the agent configuration #129929

merged 3 commits into from
Apr 12, 2022

Conversation

cauemarcondes
Copy link
Contributor

fixes #129445

enviroment.selected.mov

E2E test:
Screen Shot 2022-04-11 at 2 08 42 PM

@cauemarcondes cauemarcondes added release_note:fix Team:APM All issues that need APM UI Team support auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Apr 11, 2022
@cauemarcondes cauemarcondes requested a review from a team as a code owner April 11, 2022 18:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes
Copy link
Contributor Author

E2E succeeded 50 times on my machine and broke in the first time CI runs 🤡🤡🤡🤡🤡🤡🤡🤡

Screen Shot 2022-04-11 at 3 31 53 PM

kpatticha
kpatticha approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍 LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +175.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit a395f41 into elastic:main Apr 12, 2022
@cauemarcondes cauemarcondes deleted the apm-agent-config-environment branch April 12, 2022 15:40
@kibanamachine kibanamachine mentioned this pull request Apr 12, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 12, 2022
@cauemarcondes
[APM] Service environment should be selected when you edit the agent …
dbc7a72 
…configuration (#129929)

* fixing env selected

* lets see if it works now

* fixing test

(cherry picked from commit a395f41)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

cauemarcondes added a commit that referenced this pull request Apr 12, 2022
@kibanamachine @cauemarcondes
[APM] Service environment should be selected when you edit the agent …
7bb8cd0 
…configuration (#129929) (#130034)

* fixing env selected

* lets see if it works now

* fixing test

(cherry picked from commit a395f41)

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpatticha kpatticha kpatticha approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Service environment should be selected when you edit the agent configuration
5 participants
@cauemarcondes @elasticmachine @kibana-ci @kibanamachine @kpatticha