Failing test: Firefox UI Functional Tests.test/functional/apps/discover/_field_data_with_fields_api·ts - discover app discover tab with new fields API field data shows top-level object keys #129844
Conversation
…er/_field_data_with_fields_api·ts - discover app discover tab with new fields API field data shows top-level object keys
DianaDerevyankina
added
release_note:skip
There was a problem hiding this comment.
Flaky fix LGTM 👍 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/409
Thx a lot!
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
|
||
| const field = await PageObjects.discover.getDocTableIndex(1); | ||
| expect(field).to.contain('relatedContent.url'); | ||
| const field = await PageObjects.discover.getDocTableIndex(1); |
There was a problem hiding this comment.
Yes, this change fixes the problem, but strategically, I still would like to not put try-retry in different places where we have a problem. Tests should be readable, and such logic is placed in PageObjects.
There was a problem hiding this comment.
I agree we could improve it, but also I think it should not block from moving forward
| @@ -92,12 +91,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
| hash.replace('columns:!()', 'columns:!(relatedContent)'), | |||
| { useActualUrl: true } | |||
| ); | |||
|
|
|||
| await PageObjects.header.waitUntilLoadingHasFinished(); | |||
There was a problem hiding this comment.
Does this mean that we need to add this to all places where navigation in Discover occurs?
There was a problem hiding this comment.
It depends: if initially there's check of field list or the document table required, PageObjects.header.waitUntilLoadingHasFinished is recommended
|
@elasticmachine merge upstream |
|
|
||
| const field = await PageObjects.discover.getDocTableIndex(1); | ||
| expect(field).to.contain('relatedContent.url'); | ||
| const field = await PageObjects.discover.getDocTableIndex(1); |
There was a problem hiding this comment.
I agree we could improve it, but also I think it should not block from moving forward
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…er/_field_data_with_fields_api·ts - discover app discover tab with new fields API field data shows top-level object keys (#129844) (#130104) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit f814e0f) Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com>
Closes #127905
Summary
Added
waitUntilLoadingHasFinishedbefore expect checks and wrap them intoretry.try.For maintainers