Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node instead of webpack config for jest #12974

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

weltenwort
Copy link
Member

This allows for testing components that use generators or async/await as
well as for the usage of these features in the tests files.

There is a separate issue with the jest cache being invalidated when some of our configuration files changed, but that will be tackled in a different PR.

@weltenwort weltenwort added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v5.6.0 v6.0.0-beta1 labels Jul 19, 2017
@weltenwort weltenwort self-assigned this Jul 19, 2017
@weltenwort weltenwort requested review from cjcenizal and spalger July 19, 2017 17:09
@weltenwort
Copy link
Member Author

The test failure is about a license not being permissible. Seems to be unrelated, since this did not change any dependencies.

jenkins, test this

@cjcenizal
Copy link
Contributor

@weltenwort I think you just need to rebase master. A fix for the ua-parser license was just merged recently.

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ran the tests locally and they all worked as expected.

This allows for testing components that use generators or async/await as
well as for the usage of these features in the tests files.
@weltenwort weltenwort force-pushed the fix/babel-jest-node-config branch from a1051c6 to 0d7d5d5 Compare July 19, 2017 18:37
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weltenwort weltenwort merged commit b7d1b46 into elastic:master Jul 21, 2017
weltenwort added a commit to weltenwort/kibana that referenced this pull request Jul 21, 2017
weltenwort added a commit that referenced this pull request Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v5.6.0 v6.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants