-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node instead of webpack config for jest #12974
Use node instead of webpack config for jest #12974
Conversation
The test failure is about a license not being permissible. Seems to be unrelated, since this did not change any dependencies. jenkins, test this |
@weltenwort I think you just need to rebase master. A fix for the ua-parser license was just merged recently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ran the tests locally and they all worked as expected.
This allows for testing components that use generators or async/await as well as for the usage of these features in the tests files.
a1051c6
to
0d7d5d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This allows for testing components that use generators or async/await as
well as for the usage of these features in the tests files.
There is a separate issue with the jest cache being invalidated when some of our configuration files changed, but that will be tackled in a different PR.