-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Handle multiple request exceptions #129443
[Console] Handle multiple request exceptions #129443
Conversation
7b4f983
to
8be756e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good for me :)
8be756e
to
2e31b0b
Compare
@elasticmachine merge upstream |
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for patching this up @mibragimov! code changes lgtm, tested locally.
I just have a few UX concerns about the changes:
- When multiple requests are sent the http status label only shows the state of the last one, even though there were a few that failed. Not sure how this could be addressed though.
- It's not very obvious from the output shown in the preview panel which request failed and which one didn't. Is it possible to highlight it somehow or show something next to line numbers? We could potentially do this with a separate issue though, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a new issue for tracking those two UX concerns #130982
src/plugins/console/public/application/hooks/use_send_current_request/send_request.test.ts
Outdated
Show resolved
Hide resolved
src/plugins/console/public/application/hooks/use_send_current_request/send_request.ts
Outdated
Show resolved
Hide resolved
- Extract a way of getting content-type to a separate function
c27d588
to
0e0f459
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mibragimov |
* Add handling multiple request exceptions - Fix code styling for send_request.test.ts - Extract a way of getting content-type to a separate function Co-authored-by: Muhammad Ibragimov <muhammad.ibragimov@elastic.co>
Closes #78919
Summary
Fixes outputting multiple request results with exceptions in editor output.
Testing
To test this out, send the following requests at once
Release Note
Console now supports properly handling multiple requests. For es errors such as
400
,405
exception results are displayed with successful request results in the order they called. For non-es errors such as500
, it outputs only the first exception result.Screenshots