Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Fixes the unclickable panel menu for all the pie charts #129290

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[Visualize] Fixes the unclickable panel menu for all the pie charts #129290

merged 1 commit into from
Apr 4, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 4, 2022 •
edited
Loading

Summary

Closes #129256

The bug exists in 8.2+. If you embed a visualize pie on a dashboard, the menu (clicking the gear icon) is unreachable.
The problem is the css. Check the screenshot below:

image (17)

As you can see the embeddable wrapper is above the menu icon and as a result is not clickable. The problem is that we are creating an absolute positioned wrapper while the parent is not relative.

This PR is fixing the problem by adding the relative position to the parent wrapper.

image (18)

@stratoula stratoula added Feature:Pie Chart Pie chart visualization feature release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 labels Apr 4, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionPartitionVis 21.9KB 21.9KB +24.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Apr 4, 2022
@stratoula stratoula marked this pull request as ready for review April 4, 2022 09:42
@stratoula stratoula requested a review from a team as a code owner April 4, 2022 09:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

flash1293
flash1293 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected for me, LGTM

@stratoula stratoula merged commit 32599aa into elastic:main Apr 4, 2022
kibanamachine pushed a commit that referenced this pull request Apr 4, 2022
@stratoula
[Visualize] Fixes the unclickable panel menu for all the pie charts (#…
5c2422c 
…129290)

(cherry picked from commit 32599aa)
@kibanamachine kibanamachine mentioned this pull request Apr 4, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 4, 2022
@kibanamachine @stratoula
[Visualize] Fixes the unclickable panel menu for all the pie charts (#…
e991edb 
…129290) (#129330)

(cherry picked from commit 32599aa)

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
@bhavyarm bhavyarm mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Pie Chart Pie chart visualization feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard edit panel menu doesn't show on pie chart visualization with two drilldowns upgraded from 7.17
5 participants
@stratoula @kibana-ci @elasticmachine @kibanamachine @flash1293