Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix the nodes_overview endpoint #129215

Merged
merged 1 commit into from
Apr 1, 2022
Merged

[ML] Fix the nodes_overview endpoint #129215

merged 1 commit into from
Apr 1, 2022

Conversation

darnautov
Copy link
Contributor

Summary

Filters out the _ml/memory/_stats response for nodes with ml role.

Checklist

@darnautov darnautov added :ml release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:ML Team label for ML (also use :ml) v8.2.0 v8.3.0 labels Apr 1, 2022
@darnautov darnautov self-assigned this Apr 1, 2022
@darnautov darnautov requested a review from a team as a code owner April 1, 2022 15:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@darnautov darnautov enabled auto-merge (squash) April 1, 2022 15:42
pheyos
pheyos approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested with a local 8-node cluster and the ML node list no longer displayed all nodes, but just the ML ones.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 02dca37 into elastic:main Apr 1, 2022
@kibanamachine kibanamachine mentioned this pull request Apr 1, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 1, 2022
@darnautov
[ML] Fix the nodes_overview endpoint (#129215)
01cb06d 
(cherry picked from commit 02dca37)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 1, 2022
@kibanamachine @darnautov
[ML] Fix the nodes_overview endpoint (#129215) (#129227)
0570266 
(cherry picked from commit 02dca37)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @pheyos @peteharverson