[K7] Add Icon component #12920
Merged
[K7] Add Icon component #12920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
the
Team:Platform-Design
cjcenizal
commented
Jul 17, 2017
| @@ -206,7 +206,7 @@ | |||
| "@elastic/eslint-plugin-kibana-custom": "1.0.3", | |||
| "angular-mocks": "1.4.7", | |||
| "babel-eslint": "7.2.3", | |||
| "bemify": "0.1.4", | |||
| "bemify": "0.1.2", | |||
There was a problem hiding this comment.
I had to downgrade because it doesn't look like 0.1.4 exists yet: https://www.npmjs.com/package/bemify
snide
approved these changes
Jul 17, 2017
| @include component('kuiIcon') { | ||
| display: inline-block; | ||
|
|
||
| @include modifier('xSmall') { |
There was a problem hiding this comment.
Can delete anything below 16px. We never go below 16px and I'd rather not even allow it. They become unreadable.
| <path id="search-a" d="M11.2709852,11.9779932 L15.14275,15.85075 C15.24075,15.94775 15.36875,15.99675 15.49675,15.99675 C15.62475,15.99675 15.75275,15.94775 15.85075,15.85075 C16.04575,15.65475 16.04575,15.33875 15.85075,15.14275 L12.2861494,11.5790625 C14.6668581,8.83239759 14.5527289,4.65636993 11.9437617,2.04675 C9.21444459,-0.68225 4.77355568,-0.68225 2.04623804,2.04675 C-0.682079347,4.77575 -0.682079347,9.21775 2.04623804,11.94675 C3.36890712,13.26875 5.12646738,13.99675 6.99499989,13.99675 C7.27093085,13.99675 7.49487482,13.77275 7.49487482,13.49675 C7.49487482,13.22075 7.27093085,12.99675 6.99499989,12.99675 C5.39240085,12.99675 3.88677755,12.37275 2.7530612,11.23975 C0.414646258,8.89975 0.414646258,5.09375 2.7530612,2.75375 C5.09047639,0.41375 8.89552438,0.41475 11.2369386,2.75375 C13.5753535,5.09375 13.5753535,8.89975 11.2369386,11.23975 C11.0419873,11.43475 11.0419873,11.75175 11.2369386,11.94675 C11.2479153,11.9577858 11.2592787,11.9682002 11.2709852,11.9779932 Z"/> | ||
| </defs> | ||
| <g fill="none" fill-rule="evenodd" transform="translate(1 1)"> | ||
| <mask id="search-b" fill="#fff"> |
There was a problem hiding this comment.
Might want to look at what's coming out of these exports. Likely, depending on what layer you're selecting to export, it's pulling in some junk from sketch. Not a big deal for now if it looks fine in the render.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jul 19, 2017
* Use bemify v0.1.2. * Add Icon component with SVG icon support. Add Search and User icons.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 16, 2017
* Use bemify v0.1.2. * Add Icon component with SVG icon support. Add Search and User icons.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 26, 2017
* Use bemify v0.1.2. * Add Icon component with SVG icon support. Add Search and User icons.
cjcenizal
added a commit
that referenced
this pull request
Sep 19, 2017
* Use bemify v0.1.2. * Add Icon component with SVG icon support. Add Search and User icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kjbekkelund Here's an example of the bemify mixins in use, in case you're interested.