Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops] Fixing issue with empty row in execution log table when rule is running #129151

Merged
merged 4 commits into from
Apr 1, 2022
Merged

[Response Ops] Fixing issue with empty row in execution log table when rule is running #129151

merged 4 commits into from
Apr 1, 2022

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Apr 1, 2022 •
edited
Loading

Resolves #129126

Summary

Updates the exec log aggregation to exclude execute-start events. This prevents an empty row from being returned for currently running rule executions.

To Verify

See description in #129126 to reproduce the issue. With this branch, you should no longer see an empty row returned while a rule is mid-execution.

Checklist

@ymao1 ymao1 force-pushed the alerting/exclude-execute-start branch 2 times, most recently from 4009c45 to 0a2686a Compare April 1, 2022 12:20
@ymao1 ymao1 force-pushed the alerting/exclude-execute-start branch from bdb40f4 to 1cb70d4 Compare April 1, 2022 12:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 changed the title Excluding execute-start events from exec log [Response Ops] Fixing issue with empty row in execution log table when rule is running Apr 1, 2022
@ymao1 ymao1 self-assigned this Apr 1, 2022
@ymao1 ymao1 added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.2.0 v8.3.0 labels Apr 1, 2022
@ymao1 ymao1 marked this pull request as ready for review April 1, 2022 14:44
@ymao1 ymao1 requested a review from a team as a code owner April 1, 2022 14:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ersin-erdal
ersin-erdal approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikecote
mikecote approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Empty rows no longer showing 👍

@ymao1 ymao1 merged commit 8291a22 into elastic:main Apr 1, 2022
@ymao1 ymao1 deleted the alerting/exclude-execute-start branch April 1, 2022 17:06
@kibanamachine kibanamachine mentioned this pull request Apr 1, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 1, 2022
@ymao1
[Response Ops] Fixing issue with empty row in execution log table whe…
2007f90 
…n rule is running (#129151)

* Excluding execute-start events from exec log

* Fixing checks

* Adding functional tests

(cherry picked from commit 8291a22)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 1, 2022
@kibanamachine @ymao1
[Response Ops] Fixing issue with empty row in execution log table whe…
566459d 
…n rule is running (#129151) (#129231)

* Excluding execute-start events from exec log

* Fixing checks

* Adding functional tests

(cherry picked from commit 8291a22)

Co-authored-by: Ying Mao <ying.mao@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@ersin-erdal ersin-erdal ersin-erdal approved these changes

Assignees

@ymao1 ymao1

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a rule is running, the run history displays an empty row
6 participants
@ymao1 @kibana-ci @elasticmachine @kibanamachine @mikecote @ersin-erdal