Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering imported dashboards in import saved objects between version tests and refactor of multi-space imports test #129065

Merged
merged 15 commits into from
Apr 4, 2022
Merged

Rendering imported dashboards in import saved objects between version tests and refactor of multi-space imports test #129065

merged 15 commits into from
Apr 4, 2022

Conversation

bhavyarm
Copy link
Contributor

  • Modified import saved objects between versions test to render - two dashboards. One has by reference panels with drilldowns. The other has both time series and non timeseries data
  • Refactored multi-space import to move a couple of methods to page objects

@bhavyarm bhavyarm self-assigned this Mar 31, 2022
@bhavyarm bhavyarm added Feature:Saved Objects Management test_xpack_functional release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 v8.1.3 labels Mar 31, 2022
@bhavyarm bhavyarm marked this pull request as ready for review March 31, 2022 17:13
@bhavyarm bhavyarm requested review from LeeDr and dmlemeshko March 31, 2022 17:13
LeeDr
LeeDr approved these changes Mar 31, 2022
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code and results review

x-pack/test/functional/apps/saved_objects_management/multi_space_import.ts Show resolved Hide resolved
dmlemeshko
dmlemeshko reviewed Apr 1, 2022
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job!
nit: spacing b/w each PO action is not needed

x-pack/test/functional/apps/saved_objects_management/multi_space_import.ts Outdated Show resolved Hide resolved
x-pack/test/functional/apps/saved_objects_management/multi_space_import.ts Outdated Show resolved Hide resolved
x-pack/test/functional/apps/saved_objects_management/multi_space_import.ts Outdated Show resolved Hide resolved
@bhavyarm bhavyarm requested a review from dmlemeshko April 1, 2022 16:37
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Apr 1, 2022

Flaky test run - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/371

dmlemeshko
dmlemeshko approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm bhavyarm merged commit e2e8dbb into elastic:main Apr 4, 2022
@kibanamachine kibanamachine mentioned this pull request Apr 4, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 4, 2022
@bhavyarm
Rendering imported dashboards in import saved objects between version…
e26ab46 
… tests and refactor of multi-space imports test (#129065)

(cherry picked from commit e2e8dbb)
kibanamachine pushed a commit that referenced this pull request Apr 4, 2022
@bhavyarm
Rendering imported dashboards in import saved objects between version…
a34794a 
… tests and refactor of multi-space imports test (#129065)

(cherry picked from commit e2e8dbb)
@kibanamachine kibanamachine mentioned this pull request Apr 4, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 4, 2022
@kibanamachine @bhavyarm
Rendering imported dashboards in import saved objects between version…
ef6507b 
… tests and refactor of multi-space imports test (#129065) (#129346)

(cherry picked from commit e2e8dbb)

Co-authored-by: Bhavya RM <bhavya@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 4, 2022
@kibanamachine @bhavyarm
Rendering imported dashboards in import saved objects between version…
f912855 
… tests and refactor of multi-space imports test (#129065) (#129345)

(cherry picked from commit e2e8dbb)

Co-authored-by: Bhavya RM <bhavya@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@LeeDr LeeDr LeeDr approved these changes

Assignees

@bhavyarm bhavyarm

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Saved Objects Management release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.1.3 v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @kibana-ci @kibanamachine @dmlemeshko @LeeDr