Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix URI param encoding on user and host details page #129064

Merged
merged 2 commits into from
Apr 4, 2022
Merged

[Security Solution] Fix URI param encoding on user and host details page #129064

merged 2 commits into from
Apr 4, 2022

Conversation

machadoum
Copy link
Member

issue: #129030

Summary

We displayed the host and user name directly from the URL without decoding it first.

Screenshot 2022-03-31 at 14 59 38

Checklist

@machadoum machadoum added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Explore v8.2.0 labels Mar 31, 2022
@machadoum machadoum requested a review from a team as a code owner March 31, 2022 13:04
@machadoum machadoum self-assigned this Mar 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@machadoum machadoum enabled auto-merge (squash) April 4, 2022 09:31
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #1 / APM API tests trial apm_mappings_only_8.0.0 fetching service anomalies with a trial license checks if alert is active

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.9MB 4.9MB +40.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 5b82971 into elastic:main Apr 4, 2022
@kibanamachine kibanamachine mentioned this pull request Apr 4, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 4, 2022
@machadoum
[Security Solution] Fix URI param encoding on user and host details p…
619dc08 
…age (#129064)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5b82971)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

machadoum added a commit that referenced this pull request Apr 5, 2022
@machadoum
[Security Solution] Fix URI param encoding on user and host details p…
a1fc607 
…age (#129064)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5b82971)
kibanamachine added a commit that referenced this pull request Apr 5, 2022
@kibanamachine @machadoum
[Security Solution] Fix URI param encoding on user and host details p…
4539f2a 
…age (#129064) (#129306)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5b82971)

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@machadoum machadoum

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@machadoum @elasticmachine @kibana-ci @kibanamachine @angorayc