[Security Solution] Changed landing page navigation #129000

YulNaumenko · 2022-03-31T03:46:04Z

Summary

Changes done in the current PR:

UX for the landing page: it corresponds to the option 2 from the suggestions of Design team

This this the behavior for the empty Security:

Screen.Recording.2022-03-30.at.9.58.27.PM.mov

New navigation leads to the Getting started page from the all global navigation links (not depends if the data is added or not):

If there is no data the landing page will be displayed for the hosts, network, overview, users and timelines components without redirecting to the Getting started page.

@bfishel, @adamwdraper please need your confirmation or comments on the new navigation:

there is a suggestion to have a Getting started page itself wide, but the landing pages from the Security pages not full with (keep the width of the old empty overview page). This is another recording. What do you think?

Screen.Recording.2022-03-30.at.10.02.04.PM.mov

I'm not sure about the behavior where some pages like hosts, network, overview show the Getting started, but some like alerts, rules, cases do not.

cc: @paulewing @asnehalb

component for overview_empty removed
moved LandingCards to the security_solution common components
created LandingPage component which reused for displaying landing page for the hosts, network, overview, users and timelines components.

TODO: Complete tests coverage.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

elasticmachine · 2022-03-31T03:48:53Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2022-03-31T03:48:54Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

Bamieh

core only owns 1 file (updated overviewIDs) lgtm 👍 please let me know if you want a more thorough review

semd · 2022-03-31T14:16:36Z

x-pack/plugins/security_solution/public/network/pages/network.test.tsx

@@ -26,7 +26,7 @@ import { Network } from './network';
 import { NetworkRoutes } from './navigation';
 import { mockCasesContract } from '../../../../cases/public/mocks';
 import { APP_UI_ID, SecurityPageName } from '../../../common/constants';
-import { getAppLandingUrl } from '../../common/components/link_to/redirect_to_overview';
+import { getAppLandingUrl } from '../../common/components/link_to';


shouldn't the import be from '../../common/components/link_to/redirect_to_landing';?

./redirect_to_overview is exported in /link_to/index.ts, but I think I can refactor this by removing unnecessary.

semd · 2022-03-31T14:29:46Z

Just one question. Do we want the "Getting Started" link to be available from the global navigation? And in case we want it, should it be in the last position? screenshot:

In case we want to change it, this is controlled by deepLinks (at x-pack/plugins/security_solution/public/app/deep_links/index.ts) using navLinkStatus and order props.

YulNaumenko · 2022-03-31T20:25:26Z

ust one question. Do we want the "Getting Started" link to be available from the global navigation? And in case we want it, should it be in the last position? screenshot:

@semd thank you for catching this!

…content for security template

YulNaumenko · 2022-04-01T00:21:44Z

@elasticmachine merge upstream

semd

LGTM 🚀

kibana-ci · 2022-04-02T04:50:19Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.9MB	4.9MB	-472.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	309.1KB	309.1KB	+3.0B
`securitySolution`	250.7KB	250.7KB	-2.0B
total			+1.0B

History

💔 Build #35407 failed fc59415
💔 Build #35387 failed 3961f4e
💔 Build #35383 failed da55c0e
💔 Build #35374 failed 8845913
💔 Build #35369 failed 2d65773

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

* [Security Solution] Changed landing page navigation * made all landings big * removed getting started from the main left menu; centered empty page content for security template * fixed linting rules * fixed linting rules * fixed tests * fixed tests * fixed tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit a0cf450)

YulNaumenko · 2022-04-04T15:14:27Z

💚 All backports created successfully

Status	Branch	Result
✅	8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

* [Security Solution] Changed landing page navigation * made all landings big * removed getting started from the main left menu; centered empty page content for security template * fixed linting rules * fixed linting rules * fixed tests * fixed tests * fixed tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit a0cf450)

[Security Solution] Changed landing page navigation

73446a1

YulNaumenko requested review from a team as code owners March 31, 2022 03:46

YulNaumenko self-assigned this Mar 31, 2022

YulNaumenko added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore labels Mar 31, 2022

YulNaumenko added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 v8.2.0 labels Mar 31, 2022

made all landings big

36c7fb6

Bamieh approved these changes Mar 31, 2022

View reviewed changes

semd reviewed Mar 31, 2022

View reviewed changes

removed getting started from the main left menu; centered empty page …

2d65773

…content for security template

YulNaumenko requested a review from semd March 31, 2022 22:35

YulNaumenko added 2 commits March 31, 2022 15:49

fixed linting rules

8845913

fixed linting rules

ec39aeb

kibanamachine and others added 3 commits March 31, 2022 20:21

Merge branch 'main' into security-solution-landing-page-fix

da55c0e

fixed tests

3961f4e

fixed tests

fc59415

semd approved these changes Apr 1, 2022

View reviewed changes

fixed tests

e467c1d

YulNaumenko enabled auto-merge (squash) April 2, 2022 04:31

YulNaumenko merged commit a0cf450 into elastic:main Apr 2, 2022

YulNaumenko mentioned this pull request Apr 4, 2022

[8.2] [Security Solution] Changed landing page navigation (#129000) #129366

Merged

stephmilovic mentioned this pull request Apr 4, 2022

[Security Solution] Position of new landing page "Getting Started" is different in kibana navigation and security navigation #128580

Closed

This was referenced Apr 13, 2022

[DOCS] New "Getting Started" landing page elastic/security-docs#1835

Closed

[DOCS] New "Users" landing page elastic/security-docs#1840

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Changed landing page navigation #129000

[Security Solution] Changed landing page navigation #129000

YulNaumenko commented Mar 31, 2022 •

edited

Loading

elasticmachine commented Mar 31, 2022

elasticmachine commented Mar 31, 2022

Bamieh left a comment

semd Mar 31, 2022 •

edited

Loading

YulNaumenko Mar 31, 2022

semd commented Mar 31, 2022

YulNaumenko commented Mar 31, 2022 •

edited

Loading

YulNaumenko commented Apr 1, 2022

semd left a comment

kibana-ci commented Apr 2, 2022

YulNaumenko commented Apr 4, 2022

[Security Solution] Changed landing page navigation #129000

[Security Solution] Changed landing page navigation #129000

Conversation

YulNaumenko commented Mar 31, 2022 • edited Loading

Summary

Checklist

elasticmachine commented Mar 31, 2022

elasticmachine commented Mar 31, 2022

Bamieh left a comment

Choose a reason for hiding this comment

semd Mar 31, 2022 • edited Loading

Choose a reason for hiding this comment

YulNaumenko Mar 31, 2022

Choose a reason for hiding this comment

semd commented Mar 31, 2022

YulNaumenko commented Mar 31, 2022 • edited Loading

YulNaumenko commented Apr 1, 2022

semd left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 2, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

YulNaumenko commented Apr 4, 2022

💚 All backports created successfully

Questions ?

YulNaumenko commented Mar 31, 2022 •

edited

Loading

semd Mar 31, 2022 •

edited

Loading

YulNaumenko commented Mar 31, 2022 •

edited

Loading