-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM} Add refine search prompt to rule execution log #128982
Merged
JiaweiWu
merged 5 commits into
elastic:main
from
JiaweiWu:issue-128811-prompt-to-refine-search
Apr 5, 2022
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f88bd9a
Refine search prompt
JiaweiWu 7d06b67
Merge branch 'main' into issue-128811-prompt-to-refine-search
kibanamachine 61782ed
Fix lint
JiaweiWu fdf2bcf
Merge branch 'main' into issue-128811-prompt-to-refine-search
kibanamachine 3bc58a2
Add refine prompt to error log table
JiaweiWu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
...ins/triggers_actions_ui/public/application/sections/rule_details/refine_search_prompt.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import React, { useMemo } from 'react'; | ||
import { EuiLink, EuiText, useEuiTheme } from '@elastic/eui'; | ||
import { FormattedMessage } from '@kbn/i18n-react'; | ||
|
||
interface RefineSearchFooterProps { | ||
documentSize: number; | ||
visibleDocumentSize?: number; | ||
backToTopAnchor: string; | ||
} | ||
|
||
const DEFAULT_VISIBLE_THRESHOLD = 500; | ||
|
||
export const RefineSearchPrompt = (props: RefineSearchFooterProps) => { | ||
const { | ||
documentSize = 0, | ||
visibleDocumentSize = DEFAULT_VISIBLE_THRESHOLD, | ||
backToTopAnchor, | ||
} = props; | ||
|
||
const { euiTheme } = useEuiTheme(); | ||
|
||
const textStyles = useMemo( | ||
() => ({ | ||
backgroundColor: euiTheme.colors.lightestShade, | ||
padding: `${euiTheme.size.m} ${euiTheme.size.base}`, | ||
marginTop: `${euiTheme.size.xs}`, | ||
}), | ||
[euiTheme] | ||
); | ||
|
||
if (documentSize < visibleDocumentSize) { | ||
return null; | ||
} | ||
|
||
return ( | ||
<EuiText style={textStyles} textAlign="center" size="s"> | ||
<FormattedMessage | ||
id="xpack.triggersActionsUI.sections.ruleDetails.refineSearchPrompt.prompt" | ||
defaultMessage="These are the first {documentSize} matching your search, refine your search to see others." | ||
values={{ documentSize }} | ||
/> | ||
| ||
<EuiLink href={`#${backToTopAnchor}`}> | ||
<FormattedMessage | ||
id="xpack.triggersActionsUI.sections.ruleDetails.refineSearchPrompt.backToTop" | ||
defaultMessage="Back to top." | ||
/> | ||
</EuiLink> | ||
</EuiText> | ||
); | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!