Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] Move authentication UI and hooks to 'public/common' #128924

Merged
merged 2 commits into from
Apr 4, 2022
Merged

[Security Solutions] Move authentication UI and hooks to 'public/common' #128924

merged 2 commits into from
Apr 4, 2022

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Mar 30, 2022 •
edited
Loading

issue: #128362

Summary

  • Move authentication server to users factory
  • Move authentication UI to public/common
  • Add stackedByField to the authentication server. It will be used for the User details page
  • Create an entry into the user store for the authentication table (It was previously using the host store on User page)

What to test it?

  • Auth table on the User details page
  • Auth table on the Host page (disable usersEnabledflag)
  • Auth table on the User page (enable usersEnabledflag)

Checklist

@machadoum machadoum added refactoring release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore labels Mar 30, 2022
@machadoum machadoum requested a review from a team as a code owner March 30, 2022 15:28
@machadoum machadoum self-assigned this Mar 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum force-pushed the siem-explore-issue-128362 branch 4 times, most recently from c9ea844 to ecf906c Compare March 31, 2022 11:11
@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@machadoum machadoum force-pushed the siem-explore-issue-128362 branch 2 times, most recently from 3db8867 to dcb1c49 Compare March 31, 2022 13:25
semd
semd reviewed Apr 1, 2022
View reviewed changes
...ns/security_solution/common/search_strategy/security_solution/users/authentications/index.ts

export enum AuthStackByField {
userName = 'user.name',
hostName = 'host.name',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the AuthStackByField.hostName ever used? I only see it in tests. It seems we always stack by userName?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. Only user.name is being used. However, host.name is necessary for this issue: #129047

@machadoum
Copy link
Member Author

@elasticmachine merge upstream

semd
semd approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@machadoum machadoum force-pushed the siem-explore-issue-128362 branch from e1bd3cc to f8cd090 Compare April 4, 2022 09:06
@machadoum machadoum enabled auto-merge (squash) April 4, 2022 09:31
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3017 3025 +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.9MB 4.9MB +662.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 250.7KB 251.5KB +800.0B

History

  • 💚 Build #35225 succeeded dcb1c49a89f042fafce198d4260bd5c089c843a6
  • 💔 Build #35191 failed 67c0872e2c882c922b4fb70851b96d53808d74f9
  • 💔 Build #35142 failed bfd5371644ddd9bf935fd2f80b79787099c7e339
  • 💔 Build #34905 failed 92aed7cfcd337b98249ac72098d3e197c99ddcaa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 9e1fd5e into elastic:main Apr 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

Assignees

@machadoum machadoum

Labels
backport:skip This commit does not require backporting refactoring release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@machadoum @elasticmachine @kibana-ci @semd @kibanamachine