[Cases] Refactor: AllCasesList component in selection mode should only select #128915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
force-pushed
the
refactor/remove-postcomment-from-allcases-list
branch
from
ffc6d22 to
3183d44
Compare
added 4 commits
March 30, 2022 15:52
academo
added
release_note:skip
added 3 commits
March 31, 2022 13:24
…tcomment-from-allcases-list
…tcomment-from-allcases-list
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
5 tasks
cnasikas
reviewed
Apr 1, 2022
cnasikas
reviewed
Apr 1, 2022
...ses/public/components/all_cases/selector_modal/use_cases_add_to_existing_case_modal.test.tsx
Outdated
Show resolved
Hide resolved
cnasikas
reviewed
Apr 1, 2022
...ses/public/components/all_cases/selector_modal/use_cases_add_to_existing_case_modal.test.tsx
Outdated
Show resolved
Hide resolved
…tcomment-from-allcases-list
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @academo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially refactors the
AllCasesListcomponent to not accept attachments. This PR doesn't touch any business logic or change any UX or UI.This will keep the component as a listing and selection only component with no side effects.
The logic before available inside the component was moved to the existing hook to select and attach to a case.
In addition it removes a deprecated prop
alertDataand unused propupdateCaseIt also fixes: #128723
Checklist
Delete any items that are not applicable to this PR.