-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vega] Add back setMapView function #128914
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on Chrome, LGTM 🆗
⚪ Backport skippedThe pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Fixes #126459
This PR fixes the regression introduced by the switch to mapbox. It pulls the implementation of
setMapView
from theleaftlet-vega
implementation (https://github.com/nyurik/leaflet-vega/blob/master/src/VegaLayer.js#L146-L207) into Kibana, adds types and uses the mapbox api instead of leaflet api under the hood.Can be tested with this spec:
Play around with the
setMapView
call in the last row to check the various things.