Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archive migration] 'x-pack/test/functional/es_archives/visualize/default' #128829

Merged
merged 6 commits into from
Apr 1, 2022

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Mar 29, 2022

Summary

part of: #102552

Change tests from 'x-pack/test/functional/es_archives/visualize/default'
to 'x-pack/test/functional/fixtures/kbn_archiver/visualize/default'

These tests are not passing for me locally. Enterprise Search > Content unexpectedly appears in the nav bar and causes failures. Maybe there's some setting I'm missing when I run the tests locally?

@LeeDr LeeDr requested a review from wayneseymour March 29, 2022 21:46
@LeeDr LeeDr changed the title [Archive migration] [Archive migration] 'x-pack/test/functional/es_archives/visualize/default' Mar 29, 2022
@wayneseymour
Copy link
Member

The failing test named "can view existing Visualization" is failing due to a missing index-pattern / data-view, according to the screenshot. :(

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@LeeDr
Copy link
Author

LeeDr commented Mar 31, 2022

Flaky test run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/362

50/50 runs passed

@LeeDr LeeDr added test_xpack_functional release_note:skip Skip the PR/issue when compiling release notes Feature:Functional Testing auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 31, 2022
@LeeDr LeeDr marked this pull request as ready for review March 31, 2022 22:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

await kibanaServer.savedObjects.cleanStandardList();
await kibanaServer.importExport.load(
'x-pack/test/functional/fixtures/kbn_archiver/visualize/default'
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeeDr when we discussed this previously, you mentioned that
this test should probably be in a separate PR, perhaps in the 8.0 branch,
to build the new archive, instead of 7.17.

@LeeDr LeeDr merged commit c5e2e5e into elastic:main Apr 1, 2022
kibanamachine pushed a commit that referenced this pull request Apr 1, 2022
…ault' (#128829)

* Enterprise Search causes local failure

* convert the rest of the tests using the es_archive

* add another kbn_archive for custom space saved objects

* This test needed a doc from the es_archive

(cherry picked from commit c5e2e5e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 1, 2022
…ault' (#128829) (#129233)

* Enterprise Search causes local failure

* convert the rest of the tests using the es_archive

* add another kbn_archive for custom space saved objects

* This test needed a doc from the es_archive

(cherry picked from commit c5e2e5e)

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test_xpack_functional v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants