Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NA): comparison on building allowed list of deps for production build #128803

Merged
merged 3 commits into from
Apr 1, 2022
Merged

fix(NA): comparison on building allowed list of deps for production build #128803

merged 3 commits into from
Apr 1, 2022

Conversation

mistic
Copy link
Member

@mistic mistic commented Mar 29, 2022 •
edited
Loading

This PR fixes a bug on the logic that will apply the allowed list of the discovered prod dependencies on the ones declared in the package.json.

@mistic mistic added Team:Operations Team label for Operations Team v8.2.0 v7.17.2 v8.1.2 chore release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 29, 2022
@mistic mistic marked this pull request as ready for review March 29, 2022 21:53
@mistic mistic requested a review from a team as a code owner March 29, 2022 21:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from jbudz March 29, 2022 21:54
@tylersmalley tylersmalley changed the title fix(NA): comparasion on building allowed list of deps for production build fix(NA): comparison on building allowed list of deps for production build Mar 29, 2022
jbudz
jbudz approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-21mb, ~10k files. Nice find!

@mistic
Copy link
Member Author

mistic commented Mar 31, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 2cdcb39 into elastic:main Apr 1, 2022
@kibanamachine kibanamachine mentioned this pull request Apr 1, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 1, 2022
@mistic
fix(NA): comparasion on building allowed list of deps for production …
89fedde 
…build (#128803)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 2cdcb39)
kibanamachine pushed a commit that referenced this pull request Apr 1, 2022
@mistic
fix(NA): comparasion on building allowed list of deps for production …
2cd00fc 
…build (#128803)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 2cdcb39)
@kibanamachine kibanamachine mentioned this pull request Apr 1, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 1, 2022
@mistic
fix(NA): comparasion on building allowed list of deps for production …
0166532 
…build (#128803)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 2cdcb39)
@kibanamachine kibanamachine mentioned this pull request Apr 1, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2
✅ 7.17
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 1, 2022
@kibanamachine @mistic
fix(NA): comparasion on building allowed list of deps for production …
6472bf7 
…build (#128803) (#129250)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 2cdcb39)

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 1, 2022
@kibanamachine @mistic
fix(NA): comparasion on building allowed list of deps for production …
7254eb1 
…build (#128803) (#129249)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 2cdcb39)

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 1, 2022
@kibanamachine @mistic
fix(NA): comparasion on building allowed list of deps for production …
aa3e277 
…build (#128803) (#129251)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 2cdcb39)

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.2 v8.1.2 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibana-ci @kibanamachine @jbudz