Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to elasticsearch guide #128709

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Add tests to elasticsearch guide #128709

merged 1 commit into from
Mar 29, 2022

Conversation

yakhinvadim
Copy link
Contributor

Summary

This PR is a follow-up to the original PR (#128190) and adds tests to the new functionality.

Checklist

@joemcelroy
Add tests to elasticsearch guide
267e098 
Co-authored-by: Joseph McElroy <joseph.mcelroy@elastic.co>
@yakhinvadim yakhinvadim added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Mar 29, 2022
@yakhinvadim yakhinvadim requested a review from a team March 29, 2022 03:39
@yakhinvadim yakhinvadim enabled auto-merge (squash) March 29, 2022 03:40
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1421 1422 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yakhinvadim yakhinvadim merged commit 1d112a3 into elastic:main Mar 29, 2022
@kibanamachine
Copy link
Contributor

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 128709

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128709 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2022
@yakhinvadim yakhinvadim added the backport:skip This commit does not require backporting label Mar 31, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2022
@yakhinvadim yakhinvadim added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Mar 31, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yakhinvadim @kibana-ci @kibanamachine @joemcelroy