Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Osquery] Fix small issues in alerts #128676

Merged
merged 20 commits into from
Apr 4, 2022
Merged

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Mar 28, 2022

Summary

  • Small fix that enable saving query for later from the Alerts/Timeline flyout.

  • Added a flag to hide the fullscreen toggle on ResultsTable if we are on the OsqueryAction Flyout in Alerts/Timelines. It's a temporary solution, will be replaced by passing AddToTimeline functionality in 8.3.

  • Changed required permissions to run live queries

  • Fix wrong ''Agents selected'' text under Agents dropdown on Alerts view.

@tomsonpl tomsonpl added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature v8.2.0 labels Mar 28, 2022
@tomsonpl tomsonpl self-assigned this Mar 28, 2022
@tomsonpl tomsonpl requested a review from a team as a code owner March 28, 2022 18:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

@tomsonpl
Copy link
Contributor Author

@elasticmachine merge upstream

@tomsonpl tomsonpl requested a review from a team as a code owner March 31, 2022 07:08
@tomsonpl tomsonpl added auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 labels Apr 1, 2022
@tomsonpl
Copy link
Contributor Author

tomsonpl commented Apr 4, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 997.2KB 998.3KB +1.1KB
securitySolution 4.9MB 4.9MB +18.0B
total +1.1KB
Unknown metric groups

ESLint disabled line counts

id before after diff
osquery 122 124 +2

Total ESLint disabled count

id before after diff
osquery 127 129 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@tomsonpl tomsonpl changed the title [Osquery] Fix save for later issue [Osquery] Fix small issues in alerts Apr 4, 2022
@tomsonpl tomsonpl merged commit 5d9aaeb into elastic:main Apr 4, 2022
kibanamachine pushed a commit that referenced this pull request Apr 4, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 4, 2022
(cherry picked from commit 5d9aaeb)

Co-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Osquery Security Solution Osquery feature release_note:fix Team:Asset Management Security Asset Management Team v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants