Update @elastic/elasticsearch to v8.2.0-canary.2 #128633

pgayvallet · 2022-03-28T14:27:06Z

Summary

Bump @elastic/elasticsearch to version v8.2.0-canary.2 and adapt associated TS failures and violations

…nary.2

elasticmachine · 2022-03-30T10:16:50Z

Pinging @elastic/kibana-core (Team:Core)

pgayvallet · 2022-03-30T10:17:45Z

x-pack/plugins/ml/server/models/data_frame_analytics/models_provider.ts

@@ -111,6 +111,7 @@ export function modelsProvider(client: IScopedClusterClient, mlClient: MlClient)
     * Provides the ML nodes overview with allocated models.
     */
    async getNodesOverview(): Promise<NodesOverviewResponse> {
+      // @ts-expect-error typo in type definition: MlGetMemoryStatsResponse.cluser_name


This will be fixed in the next canary version

afharo

Core changes LGTM

afharo · 2022-03-30T11:42:06Z

src/plugins/telemetry/server/telemetry_collection/get_data_telemetry/get_data_telemetry.ts

+        // @ts-expect-error 'properties' does not exist on type 'MappingMatchOnlyTextProperty'
        isECS: !!indexMappings[name]?.mappings?.properties?.ecs?.properties?.version?.type,


Yes, even if this is a proper type fix (not all mapping types accepts a properties property) this is actually a 'terrible' change for us.

TBH I blame TS a bit about this behavior:

type A = { foo: string; } type B = { bar: string; } type Composite = A | B; const test: Composite = { foo: 'hello' }; // error 'foo' does not exist on type B test.foo

I would love to have a way for TS to consider typeof test.foo as being string | undefined, but undeclared and undefined are two very distinct concepts for typescript...

alisonelizabeth

Deployment management changes LGTM - only 1 change in fetch_indices.ts

jgowdyelastic

ML changes LGTM

scottybollinger

Enterprise Search changes LGTM

efegurkan

enterprise search changes LGTM

klacabane

Infra changes LGTM

dhurley14

security solution changes LGTM.

dhurley14

security solution changes LGTM.

pgayvallet · 2022-04-01T14:37:51Z

@elasticmachine merge upstream

…nary.2

kibana-ci · 2022-04-04T07:47:22Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Default CI Group #12 / alerting api integration spaces only Alerting builtin alertTypes es_query alert runs correctly: use epoch millis - threshold on hit count < > for searchSource search type

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`kibana`	313	310	-3

History

💛 Build #35558 was flaky 2162407faecf402c89a15dc5a223918e19c49d35
💚 Build #34787 succeeded b7af04f
💔 Build #34412 failed b940d01
💔 Build #34397 failed 2029dfc
💔 Build #34371 failed 68bf558
💔 Build #34359 failed 7bde57b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Update @elastic/elasticsearch to v8.2.0-canary.2 * fix core violation * add optional properties to our type * update generated doc * add another ts-ignore * remove unused ts-expect-error * add ts-expect-error for type typo * add ts-expect-error infra code * fix more errors (cherry picked from commit 158c617)

kibanamachine · 2022-04-04T07:52:17Z

💚 All backports created successfully

Status	Branch	Result
✅	8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

* Update @elastic/elasticsearch to v8.2.0-canary.2 * fix core violation * add optional properties to our type * update generated doc * add another ts-ignore * remove unused ts-expect-error * add ts-expect-error for type typo * add ts-expect-error infra code * fix more errors (cherry picked from commit 158c617) Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>

Update @elastic/elasticsearch to v8.2.0-canary.2

b97eadb

pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Mar 28, 2022

pgayvallet mentioned this pull request Mar 28, 2022

Update dependency @elastic/elasticsearch to v8.2.0-canary.2 (main) #128491

Closed

1 task

pgayvallet added the backport:skip This commit does not require backporting label Mar 28, 2022

pgayvallet added 9 commits March 29, 2022 08:06

fix core violation

166727e

add optional properties to our type

2dbf806

update generated doc

7bde57b

add another ts-ignore

68bf558

remove unused ts-expect-error

2dccf3e

add ts-expect-error for type typo

2029dfc

add ts-expect-error infra code

b940d01

fix more errors

4af650d

Merge remote-tracking branch 'upstream/main' into kbn-xxx-ES-8.2.0-ca…

b7af04f

…nary.2

pgayvallet marked this pull request as ready for review March 30, 2022 10:16

pgayvallet requested review from a team as code owners March 30, 2022 10:16

pgayvallet requested a review from a team March 30, 2022 10:16

pgayvallet requested review from a team as code owners March 30, 2022 10:16

pgayvallet commented Mar 30, 2022

View reviewed changes

afharo approved these changes Mar 30, 2022

View reviewed changes

alisonelizabeth approved these changes Mar 30, 2022

View reviewed changes

jgowdyelastic approved these changes Mar 30, 2022

View reviewed changes

scottybollinger approved these changes Mar 30, 2022

View reviewed changes

efegurkan approved these changes Mar 30, 2022

View reviewed changes

klacabane approved these changes Mar 31, 2022

View reviewed changes

dhurley14 approved these changes Mar 31, 2022

View reviewed changes

pgayvallet added v8.3.0 v8.2.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed v8.2.0 backport:skip This commit does not require backporting labels Apr 1, 2022

Merge remote-tracking branch 'upstream/main' into kbn-xxx-ES-8.2.0-ca…

55bba66

…nary.2

pgayvallet force-pushed the kbn-xxx-ES-8.2.0-canary.2 branch from 2162407 to 55bba66 Compare April 4, 2022 06:03

pgayvallet merged commit 158c617 into elastic:main Apr 4, 2022

kibanamachine mentioned this pull request Apr 4, 2022

[8.2] Update @elastic/elasticsearch to v8.2.0-canary.2 (#128633) #129287

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update @elastic/elasticsearch to v8.2.0-canary.2 #128633

Update @elastic/elasticsearch to v8.2.0-canary.2 #128633

pgayvallet commented Mar 28, 2022 •

edited

Loading

elasticmachine commented Mar 30, 2022

pgayvallet Mar 30, 2022

afharo left a comment

afharo Mar 30, 2022

pgayvallet Mar 30, 2022 •

edited

Loading

alisonelizabeth left a comment

jgowdyelastic left a comment

scottybollinger left a comment

efegurkan left a comment

klacabane left a comment

dhurley14 left a comment

dhurley14 left a comment

pgayvallet commented Apr 1, 2022

kibana-ci commented Apr 4, 2022

kibanamachine commented Apr 4, 2022

		// @ts-expect-error 'properties' does not exist on type 'MappingMatchOnlyTextProperty'
		isECS: !!indexMappings[name]?.mappings?.properties?.ecs?.properties?.version?.type,

Update @elastic/elasticsearch to v8.2.0-canary.2 #128633

Update @elastic/elasticsearch to v8.2.0-canary.2 #128633

Conversation

pgayvallet commented Mar 28, 2022 • edited Loading

Summary

elasticmachine commented Mar 30, 2022

pgayvallet Mar 30, 2022

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

afharo Mar 30, 2022

Choose a reason for hiding this comment

pgayvallet Mar 30, 2022 • edited Loading

Choose a reason for hiding this comment

alisonelizabeth left a comment

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

scottybollinger left a comment

Choose a reason for hiding this comment

efegurkan left a comment

Choose a reason for hiding this comment

klacabane left a comment

Choose a reason for hiding this comment

dhurley14 left a comment

Choose a reason for hiding this comment

dhurley14 left a comment

Choose a reason for hiding this comment

pgayvallet commented Apr 1, 2022

kibana-ci commented Apr 4, 2022

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Public APIs missing exports

History

kibanamachine commented Apr 4, 2022

💚 All backports created successfully

Questions ?

pgayvallet commented Mar 28, 2022 •

edited

Loading

pgayvallet Mar 30, 2022 •

edited

Loading