Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K7]: KUI variable naming, sizing and responsive breakpoints #12846

Merged
merged 5 commits into from
Jul 14, 2017

Conversation

snide
Copy link
Contributor

@snide snide commented Jul 13, 2017

  • Global vars use kui variable prefix.
  • Create sizing vars
  • Add z-index vars
  • Remove everything but starter vars

@snide snide requested a review from cjcenizal July 13, 2017 23:09
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!! Just had some nitpicky suggestions.

$kuiAnimSlightBounce: cubic-bezier(0.34,1.61,0.7,1);
$kuiAnimSlightResistance: cubic-bezier(0.694, 0.0482, 0.335, 1);

$kuiAnimSpeedVeryFast: 90ms;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use "extra" instead of "very", since we're already using that in our t-shirt sizing?

$kuiAnimSpeedFast: 150ms;
$kuiAnimSpeedNormal: 250ms;
$kuiAnimSpeedSlow: 350ms;
$kuiAnimSpeedVerySlow: 500ms;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

$kuiZContentMenu: 100;
$kuiZNavigation: 200;
$kuiZMask: 300;
$kuiZModal: 400;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about increments of 1000? It doesn't hurt and gives us more room to expand in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i remember correctly, some old browsers cap at 999. If we can't work within a range of 1000 we're in trouble? haha.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some research and I think we're OK to use much much larger numbers. Looks like the max is 2147483647 in most browsers, and 16777271 in Safari 3:

@@ -0,0 +1,5 @@
$kuiZContent: 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I think this should be 0, to create even increments between levels.

@snide
Copy link
Contributor Author

snide commented Jul 13, 2017

Updated per suggestions @cjcenizal

@snide snide merged commit d538497 into elastic:k7-ui-framework Jul 14, 2017
@snide snide deleted the k7/basics branch July 14, 2017 14:27
@snide snide added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Jul 17, 2017
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Jul 19, 2017
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 16, 2017
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 26, 2017
cjcenizal pushed a commit that referenced this pull request Sep 19, 2017
variable naming, sizing and responsive breakpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants