-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K7]: KUI variable naming, sizing and responsive breakpoints #12846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!! Just had some nitpicky suggestions.
$kuiAnimSlightBounce: cubic-bezier(0.34,1.61,0.7,1); | ||
$kuiAnimSlightResistance: cubic-bezier(0.694, 0.0482, 0.335, 1); | ||
|
||
$kuiAnimSpeedVeryFast: 90ms; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should use "extra" instead of "very", since we're already using that in our t-shirt sizing?
$kuiAnimSpeedFast: 150ms; | ||
$kuiAnimSpeedNormal: 250ms; | ||
$kuiAnimSpeedSlow: 350ms; | ||
$kuiAnimSpeedVerySlow: 500ms; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here?
$kuiZContentMenu: 100; | ||
$kuiZNavigation: 200; | ||
$kuiZMask: 300; | ||
$kuiZModal: 400; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about increments of 1000
? It doesn't hurt and gives us more room to expand in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i remember correctly, some old browsers cap at 999. If we can't work within a range of 1000 we're in trouble? haha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some research and I think we're OK to use much much larger numbers. Looks like the max is 2147483647 in most browsers, and 16777271 in Safari 3:
@@ -0,0 +1,5 @@ | |||
$kuiZContent: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically I think this should be 0
, to create even increments between levels.
Updated per suggestions @cjcenizal |
…#12846) variable naming, sizing and responsive breakpoints
…#12846) variable naming, sizing and responsive breakpoints
…#12846) variable naming, sizing and responsive breakpoints
variable naming, sizing and responsive breakpoints
kui
variable prefix.