-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SharedUX] Migrate PageTemplate > NoData Page #128372
Changes from 23 commits
084afdf
e5c0b4c
5852696
7e6ee56
97e2799
4c02548
372840f
93b09e8
88fba5a
6b47699
44c5039
b65b050
a2ed0b5
5c4bfbf
534fefa
696006c
fd72939
efd4383
7bd8409
42cbf0a
4fb3975
a35a3e1
04bde2a
e278b05
167f966
adf83b1
fc2a50a
f6a40b3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ | |
*/ | ||
|
||
export { NoDataCard, ElasticAgentCard } from './no_data_page'; | ||
export { NoDataPage } from './no_data_page'; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import React from 'react'; | ||
import { servicesFactory } from '@kbn/shared-ux-storybook'; | ||
import { NoDataPageProps } from './types'; | ||
import { NoDataPage } from './no_data_page'; | ||
|
||
const services = servicesFactory({}); | ||
|
||
export default { | ||
title: 'Page Template/No Data Page/No Data Page', | ||
description: 'No Data Page of PageTemplate', | ||
}; | ||
const action = { | ||
elasticAgent: {}, | ||
}; | ||
type Params = Pick<NoDataPageProps, 'solution'>; | ||
|
||
export const PureComponent = (params: Params) => { | ||
return <NoDataPage docsLink={services.docLinks.dataViewsDocLink} action={action} {...params} />; | ||
}; | ||
|
||
PureComponent.argTypes = { | ||
solution: { | ||
control: 'text', | ||
defaultValue: 'Observability', | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Can we add a
logo
control that is blank by default?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!