-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SharedUX] Migrate PageTemplate > NoDataPage > SolutionNav #128277
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
4c02548
[SharedUX] Migrate PageTemplate > SolutionNavAvatar
b0c2032
[SharedUX] Migrate PageTemplate > NoDataPage > ActionCards
2664372
[SharedUX] Migrate PageTemplate > NoDataPage > SolutionNav
6756004
Updating snapshot
95387f2
Fix i18n
ab4e3b2
Fix index.tsx
b4a9f0f
Fix failing test
9b8877b
Remove unnecessary export
347e401
Change folder structure of solution_nav_avatar
f6d818c
[SharedUX] Migrate PageTemplate > NoDataPage > ActionCards
30534ea
[SharedUX] Migrate PageTemplate > NoDataPage > SolutionNav
ec2aa19
Updating snapshot
c476398
Fix index.tsx
db9f0c7
Fix failing test
8df73d7
Remove unnecessary export
418595e
Merge branch 'main' into page-template-3
372840f
Fix comment
88fba5a
Renaming component
6b47699
Fix folder structure
44c5039
Fix storybook
b65b050
Style fix
dcbffa4
Merge SolutionAvatar changes
96859b2
Fix SolutionAvatar reference
b6515ba
Resolving merge conflicts
0f9f73d
Merge branch 'main' into page-template-3
kibanamachine f713bae
Fix failing test
3e772af
Fix failing snapshot
8bf163d
Merge branch 'main' into page-template-3
kibanamachine b3b98b5
Merge branch 'main' into page-template-3
kibanamachine 329bc92
Applying PR comments
5e67940
Updating failing snapshot
3c1179c
Extract i18n
1b5ef2d
Merge branch 'main' into page-template-3
kibanamachine 41ffd07
collapsed > isCollapsed
f2f082f
Merge branch 'main' into page-template-3
kibanamachine 973d86a
Applying PR comments
4f4c217
Merge branch 'page-template-3' of https://github.com/majagrubic/kiban…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
267 changes: 267 additions & 0 deletions
267
...red-ux-components/src/page_template/solution_nav/__snapshots__/solution_nav.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
23 changes: 23 additions & 0 deletions
23
...s/src/page_template/solution_nav/__snapshots__/solution_nav_collapse_button.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
12 changes: 12 additions & 0 deletions
12
packages/kbn-shared-ux-components/src/page_template/solution_nav/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
export type { KibanaPageTemplateSolutionNavProps } from './solution_nav'; | ||
export { KibanaPageTemplateSolutionNav } from './solution_nav'; | ||
export type { KibanaPageTemplateSolutionNavCollapseButtonProps } from './solution_nav_collapse_button'; | ||
export { KibanaPageTemplateSolutionNavCollapseButton } from './solution_nav_collapse_button'; |
30 changes: 30 additions & 0 deletions
30
packages/kbn-shared-ux-components/src/page_template/solution_nav/solution_nav.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
$euiSideNavEmphasizedBackgroundColor: transparentize($euiColorLightShade, .7); | ||
@import '@elastic/eui/src/components/side_nav/mixins'; | ||
|
||
// Put the page background color in the flyout version too | ||
.kbnPageTemplateSolutionNav__flyout { | ||
background-color: $euiPageBackgroundColor; | ||
} | ||
|
||
.kbnPageTemplateSolutionNav { | ||
@include euiSideNavEmbellish; | ||
@include euiYScroll; | ||
|
||
@include euiBreakpoint('m' ,'l', 'xl') { | ||
width: 248px; | ||
padding: $euiSizeL; | ||
} | ||
|
||
.kbnPageTemplateSolutionNavAvatar { | ||
margin-right: $euiSize; | ||
} | ||
} | ||
|
||
.kbnPageTemplateSolutionNav--hidden { | ||
pointer-events: none; | ||
opacity: 0; | ||
|
||
@include euiCanAnimate { | ||
transition: opacity $euiAnimSpeedFast $euiAnimSlightResistance; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be imported like this. Is it acceptable to just copy the relevant styling as js constants and use them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mixin was created by EUI specifically to be used in multiple Elastic products, we don't want to duplicate styles because then they'll get out of sync. This method of importing has been fine and eventually will get converted to a JS hook. So it's ok for now.