Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adding v3 modules for Security_Linux and Security_Windows and Deprecating v1 + v2 #128099

Closed
wants to merge 26 commits into from

Conversation

bfilar
Copy link
Contributor

@bfilar bfilar commented Mar 18, 2022

Summary

Files/Job Artifacts:


  • 2 updated manifest .json files - for both linux and windows

  • Updated/new ML Job configurations for 26 jobs - each with associated datafeed configuration files:

    • security_linux: 14 jobs

      • v3_linux_anomalous_network_activity
      • v3_linux_anomalous_network_port_activity_ecs
      • v3_linux_anomalous_process_all_hosts_ecs
      • v3_linux_anomalous_user_name_ecs
      • v3_linux_network_configuration_discovery
      • v3_linux_network_connection_discovery
      • v3_linux_rare_metadata_process
      • v3_linux_rare_metadata_user
      • v3_linux_rare_sudo_user
      • v3_linux_rare_user_compiler
      • v3_linux_system_information_discovery
      • v3_linux_system_process_discovery
      • v3_linux_system_user_discovery
      • v3_rare_process_by_host_linux_ecs
    • security_windows: 12 jobs

      • v3_rare_process_by_host_windows_ecs
      • v3_windows_anomalous_network_activity_ecs
      • v3_windows_anomalous_path_activity_ecs
      • v3_windows_anomalous_process_all_hosts_ecs
      • v3_windows_anomalous_process_creation
      • v3_windows_anomalous_script
      • v3_windows_anomalous_service
      • v3_windows_anomalous_user_name_ecs
      • v3_windows_rare_metadata_process
      • v3_windows_rare_metadata_user
      • v3_windows_rare_user_runas_event
      • v3_windows_rare_user_type10_remote_login

Tests:


Individual job test tracking stats available here: https://docs.google.com/spreadsheets/d/1JOUIVsitaMdEdhM3WT2Eag4ELI-rI2Jec7bXildJsdQ/edit#gid=0

@randomuserid to also post more updates as needed to this issue + regarding tests, thanks

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

removed references to deprecated v1 modules which no longer exist
remove references to deprecated module and modify module names to match the latest v3 modules being committed.
@bfilar bfilar requested a review from a team as a code owner March 21, 2022 17:46
@randomuserid
Copy link
Contributor

@elasticmachine merge upstream

@randomuserid
Copy link
Contributor

@elasticmachine merge upstream

@spong spong requested a review from a team March 21, 2022 21:11
@peteharverson
Copy link
Contributor

One of the ML API integration tests in x-pack/test/api_integration/apis/ml/modules/setup_module.ts is failing here as it is trying to run against the siem_auditbeat_auth module which has been deleted here. I can't tell if the module_siem_auditbeat data set used in this test works against the security_auth module. If so, you could just switch the siem_auditbeat_auth module referenced in this test. If not, this test will need removing. Unless we have another data set we could use here @pheyos ?

@pheyos
Copy link
Member

pheyos commented Mar 22, 2022

Fixing the tests requires a few more adjustments, I'm currently looking into the details.

pheyos and others added 3 commits March 22, 2022 18:18
skipping this test which acts on the v1 jobs that have been deprecated
disabling security solution tests that act on v1 jobs until they can be updated to current
disable a test that needs updating due to the ML module consolidation & deprecation
@randomuserid
Copy link
Contributor

@elasticmachine merge upstream

kibanamachine and others added 4 commits March 22, 2022 21:27
disabling some ml tests as they appear to be expecting the v1 modules which have been deprecated.
@randomuserid
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB -74.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @randomuserid @bfilar

@randomuserid
Copy link
Contributor

Many of the tests need to be updated with the deprecation of the v1 modules. New tests may be needed for the v3 modules. This work will need to be costed and planned so we're moving this forward to 8.3 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants