Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend yarn es: plugin support + adding secure files to es keystore #126938

Merged

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Mar 4, 2022

Summary

Adding --plugins and --secureFiles as flags to yarn es this allows kibana devs to quickly spin up development clusters with plugins. The secureFiles helps to make it easier to add remote shared aws/gcp/azure/etc repositories to restore large datasets for development.

This allows you to run e.g

$ yarn es snapshot --plugins repository-gcs --secureFiles gcs.client.secondary.credentials_file=~/.gcp

For 8.0+ the installation for e.g repository-gcs will still run but effectively be noop since its now packaged by default.

For maintainers

@Mpdreamz Mpdreamz requested a review from a team as a code owner March 4, 2022 16:51
Mpdreamz added 2 commits March 4, 2022 17:57
This allows you to run e.g

```
 yarn es snapshot --plugins repository-gcs --secureFiles gcs.client.secondary.credentials_file=~/.gcp
```
@Mpdreamz Mpdreamz force-pushed the feature/es-snapshot-plugin-secure-files branch from 1f49f47 to f996c45 Compare March 4, 2022 16:59
packages/kbn-es/src/cluster.js Outdated Show resolved Hide resolved
packages/kbn-es/src/cluster.js Outdated Show resolved Hide resolved
packages/kbn-es/src/cluster.js Outdated Show resolved Hide resolved
packages/kbn-es/src/cli_commands/snapshot.js Outdated Show resolved Hide resolved
@Mpdreamz Mpdreamz added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Mar 7, 2022
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple nits but it seems to work well. I don't have a ~/.gcp file, but I created one and was able to get different errors from the plugin. That said, I had to replace ~/.gcp with $HOME/.gcp because bash doesn't resolve the ~ in the middle of the argument, but I don't think that's a big deal.

packages/kbn-es/src/cli_commands/source.js Outdated Show resolved Hide resolved
packages/kbn-es/src/cluster.js Show resolved Hide resolved
@Mpdreamz Mpdreamz requested a review from spalger March 8, 2022 09:06
@Mpdreamz
Copy link
Member Author

Mpdreamz commented Mar 8, 2022

Thanks for the reviews @spalger!

That said, I had to replace ~/.gcp with $HOME/.gcp because bash doesn't resolve the ~ in the middle of the argument, but I don't think that's a big deal.

Sorry bout that, I tested with the full path to my home and replaced with ~ while writing the commit message 🙂

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Mpdreamz Mpdreamz merged commit f74c894 into elastic:main Mar 9, 2022
@Mpdreamz Mpdreamz deleted the feature/es-snapshot-plugin-secure-files branch March 9, 2022 10:11
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 11, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126938 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Mar 11, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants