-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend yarn es: plugin support + adding secure files to es keystore #126938
Extend yarn es: plugin support + adding secure files to es keystore #126938
Conversation
This allows you to run e.g ``` yarn es snapshot --plugins repository-gcs --secureFiles gcs.client.secondary.credentials_file=~/.gcp ```
1f49f47
to
f996c45
Compare
Co-authored-by: Spencer <email@spalger.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple nits but it seems to work well. I don't have a ~/.gcp
file, but I created one and was able to get different errors from the plugin. That said, I had to replace ~/.gcp
with $HOME/.gcp
because bash doesn't resolve the ~
in the middle of the argument, but I don't think that's a big deal.
Thanks for the reviews @spalger!
Sorry bout that, I tested with the full path to my home and replaced with |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Adding
--plugins
and--secureFiles
as flags toyarn es
this allows kibana devs to quickly spin up development clusters with plugins. The secureFiles helps to make it easier to add remote shared aws/gcp/azure/etc repositories to restore large datasets for development.This allows you to run e.g
For 8.0+ the installation for e.g
repository-gcs
will still run but effectively benoop
since its now packaged by default.For maintainers