Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1] APM execution context - app, page, entitiy id (#124996) #126751

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Mar 3, 2022

Backport

This will backport the following commits from main to 8.1:

Questions ?

Please refer to the Backport tool documentation

* Client side execution app level context propagation

* context$ + apm rum integration

* invert the context parent \ child relationship (cc @mikhail)
move more things to top level context

* Pass down context to apm on server

* types

* eslint

* parent <> child

* docs + eslint + jest

* execution context mock

* eslint

* jest

* jest

* server jest

* check

* jest

* storybook

* jest

* report the current space

* fix server side context container

* Remove spaces for now

* docssss

* jest

* lint

* test

* docs

* revert file

* doc

* all context params are optional

* clear on page change

* lint

* ts

* skipped test again

* testing fixes

* oops

* code review #1

* code review #2

* getAsLabels

* maps inherit dashboard context

* docs

* ts

* Give common context to all vis editors

* fix test

* ts \ es \ tests

* labels

* missing types

* docsy docs

* cr #3

* improve jest

* Use editor name

* Update src/plugins/visualizations/public/visualize_app/components/visualize_editor.tsx

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>

* fix maps context

* jest tests for maps

* cr

* docs

* Update execution_context.test.ts

* docs

* lint

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
(cherry picked from commit d5416ed)

# Conflicts:
#	src/plugins/discover/public/application/context/context_app.tsx
#	x-pack/plugins/lens/public/app_plugin/app.tsx
@lizozom lizozom enabled auto-merge (squash) March 3, 2022 09:03
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 334 335 +1
kibanaReact 301 307 +6
total +7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
core 973 976 +3
kibanaReact 201 203 +2
total +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 293.4KB 293.5KB +80.0B
devTools 2.5KB 2.6KB +81.0B
discover 335.5KB 335.5KB -19.0B
kibanaReact 209.5KB 209.5KB +8.0B
lens 1.0MB 1.0MB +143.0B
maps 2.5MB 2.5MB +324.0B
visualizations 151.2KB 151.5KB +273.0B
total +890.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
core 32 33 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 292.7KB 294.3KB +1.6KB
data 452.6KB 452.8KB +147.0B
devTools 10.7KB 10.7KB +38.0B
kibanaReact 56.5KB 58.2KB +1.7KB
maps 65.7KB 65.8KB +59.0B
visualizations 43.4KB 43.6KB +155.0B
total +3.7KB
Unknown metric groups

API count

id before after diff
core 2366 2379 +13
kibanaReact 236 239 +3
total +16

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit bb9ebc2 into elastic:8.1 Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants