-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing point series chart margins #12663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Seems recent master changes in master b86f97c have broken this PR. |
6dbd9f0
to
72e17fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in regard to the the gap between the bars and the x-axis.
Since I could not reproduce the issue #12645 I can not speak to that.
seems to be failing on flaky dashboard test
jenkins, test this |
72e17fe
to
b80826d
Compare
while fixing #11930 margins were broken for split charts, this resolves that issue
Resolves #12645