Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing point series chart margins #12663

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Jul 5, 2017

while fixing #11930 margins were broken for split charts, this resolves that issue

Resolves #12645

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.5.0 v5.6.0 v6.0.0 labels Jul 5, 2017
@ppisljar ppisljar requested a review from thomasneirynck July 5, 2017 14:00
@jimgoodwin jimgoodwin added v5.5.1 and removed v5.5.0 labels Jul 6, 2017
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasneirynck
Copy link
Contributor

Seems recent master changes in master b86f97c have broken this PR.

Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in regard to the the gap between the bars and the x-axis.

Since I could not reproduce the issue #12645 I can not speak to that.

@thomasneirynck
Copy link
Contributor

seems to be failing on flaky dashboard test

 └- ✖ fail: "dashboard app dashboard time dashboard with stored timed sets quick time on open"
09:16:02.230        │        Error: expected 'This month' to equal 'Today'
09:16:02.230        │         at Assertion.assert (node_modules/expect.js/index.js:96:13)
09:16:02.230        │         at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
09:16:02.230        │         at Context.<anonymous> (test/functional/apps/dashboard/_dashboard_time.js:58:32)
09:16:02.230        │         at undefined.next (native)
09:16:02.230        │         at step (test/functional/apps/dashboard/_dashboard_time.js:1:1)
09:16:02.230        │         at test/functional/apps/dashboard/_dashboard_time.js:1:1
09:16:02.230        │         at process._tickDomainCallback (internal/process/next_tick.js:135:7)

jenkins, test this

@ppisljar ppisljar merged commit 4349a53 into elastic:master Jul 12, 2017
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jul 13, 2017
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jul 13, 2017
@ppisljar
Copy link
Member Author

backports:
5.x: 84efff0
5.5: 1185155

@ppisljar ppisljar deleted the fix/chartMargin branch July 13, 2017 07:49
@ppisljar ppisljar restored the fix/chartMargin branch September 26, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix v5.5.1 v5.6.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X axis title is not displaying properly and cutting off from the visualization
4 participants