ExecutionContext: encode all context fields when converting to header #125783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Team:Core
pgayvallet
force-pushed
the
kbn-125700-utf8-execution-context
branch
from
515e421 to
8a27a19
Compare
pgayvallet
added
the
auto-backport
mshustov
reviewed
Feb 16, 2022
| @@ -50,18 +50,23 @@ export interface IExecutionContextContainer { | |||
| } | |||
|
|
|||
| function stringify(ctx: KibanaExecutionContext): string { | |||
| const stringifiedCtx = `${ctx.type}:${ctx.name}:${encodeURIComponent(ctx.id!)}`; | |||
| const stringifiedCtx = `${encodeURIComponent(ctx.type)}:${encodeURIComponent( | |||
There was a problem hiding this comment.
It's not strictly necessary to encode type and name since Kibana controls their value. We can even add a runtime validation. OTOH, it doesn't hurt and adds some extra safety.
There was a problem hiding this comment.
since Kibana controls their value
Can't any arbitrary consumer just call core.executionContext.withContext({...someContext, name: '☺☺☺'}, () => { ... }) ? At least on the server-side?
There was a problem hiding this comment.
You can. That's why I mentioned a runtime validation. But as said, let's keep it as additional protection.
|
Pinging @elastic/kibana-core (Team:Core) |
flash1293
approved these changes
Feb 17, 2022
mshustov
approved these changes
Feb 17, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 17, 2022
…elastic#125783) * ExecutionContext: encode all context fields when converting to header value * switch back to using the vis type name instead of title for the execution context name * adapt FTR tests * fix server-side tests too (cherry picked from commit d047765)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 17, 2022
…elastic#125783) * ExecutionContext: encode all context fields when converting to header value * switch back to using the vis type name instead of title for the execution context name * adapt FTR tests * fix server-side tests too (cherry picked from commit d047765)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 17, 2022
…#125783) (#125924) * ExecutionContext: encode all context fields when converting to header value * switch back to using the vis type name instead of title for the execution context name * adapt FTR tests * fix server-side tests too (cherry picked from commit d047765) Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 17, 2022
…#125783) (#125925) * ExecutionContext: encode all context fields when converting to header value * switch back to using the vis type name instead of title for the execution context name * adapt FTR tests * fix server-side tests too (cherry picked from commit d047765) Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #125700
x-opaque-idvaluenameof the vis when creating context instead oftitleChecklist