[Fleet] Tell users when assets are installed in a different space #125278

hop-dev · 2022-02-10T17:13:43Z

Summary

Related to #74353
Previously, when an integration was installed in space 1, when viewing the assets in space 2 we would simply show "no assets found". We now display "This integration is installed, but no assets are available in this space".

Testing
I don't believe we have any cypress tests that create spaces yet so this seemed like more work than this bugfix deserves? I also believe the assets component has too many side effects for unit tests to be a good use of time here

test the message is shown correctly:

create a space "space2"
install an integration in space2
switch to the default space
view the integrations assets, the new message should be displayed

test "no assets found" still displays correctly

install "Custom UDP Logs" integration (doesnt have any assets)
view the assets tab
verify "No assets found" is displayed

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2022-02-10T17:13:45Z

Pinging @elastic/fleet (Team:Fleet)

nchaulet

LGTM 🚀

kibana-ci · 2022-02-11T12:07:42Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	567	568	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	660.1KB	660.6KB	+475.0B

History

💚 Build #23211 succeeded fcf3d7a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

kibanamachine · 2022-02-11T13:44:33Z

💚 All backports created successfully

Status	Branch	Result
✅	8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…astic#125278) * Show new message when assets installed in separate space * move variable into useEffect (cherry picked from commit a81b11e)

…25278) (#125373) * Show new message when assets installed in separate space * move variable into useEffect (cherry picked from commit a81b11e) Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>

jen-huang · 2022-02-14T20:16:13Z

...plugins/fleet/public/applications/integrations/sections/epm/screens/detail/assets/assets.tsx

@@ -13,9 +13,10 @@ import { groupBy } from 'lodash';

 import type { ResolvedSimpleSavedObject } from 'src/core/public';

+import { useKibana } from '../../../../../../../../../../../src/plugins/kibana_react/public';


just swung by this PR to backport it as a patch to 8.0 and noticed this, we have useStartServices hook which encapsulates the plugin logic added by this PR so that can be use instead of traversing all the way to the kibana_react plugin:

kibana/x-pack/plugins/fleet/public/hooks/use_core.ts

Line 11 in f4713f5

export function useStartServices(): FleetStartServices {

I believe you'd just have to add spaces to the FleetStartServices interface. I think this would be a good candidate for a small PR 😉

Amazing thanks! I'll get that done some time soon

…astic#125278) * Show new message when assets installed in separate space * move variable into useEffect (cherry picked from commit a81b11e)

kibanamachine · 2022-02-14T20:19:37Z

💚 All backports created successfully

Status	Branch	Result
✅	8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…25278) (#125573) * Show new message when assets installed in separate space * move variable into useEffect (cherry picked from commit a81b11e) Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>

dikshachauhan-qasource · 2022-02-28T09:47:28Z

Hi @jen-huang

We have validated this PR and found it working fine on 8.1.10 BC4.

"This integration is installed, but no assets are available in this space" is displayed to user when working in different space other then from where integrations were installed.
"No assets found" message displayed for integration that don't have any asset under current integration to navigate to.

Screenshot:

Build details:
BUILD: 50428
COMMIT: 015578b

Thanks
QAS

Show new message when assets installed in separate space

fcf3d7a

hop-dev added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v8.1.0 labels Feb 10, 2022

hop-dev requested a review from a team as a code owner February 10, 2022 17:13

hop-dev self-assigned this Feb 10, 2022

hop-dev added the release_note:fix label Feb 10, 2022

jen-huang added the v8.2.0 label Feb 10, 2022

nchaulet approved these changes Feb 10, 2022

View reviewed changes

move variable into useEffect

e75b330

hop-dev added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 11, 2022

hop-dev merged commit a81b11e into elastic:main Feb 11, 2022

hop-dev deleted the 74353-assets-installed-in-separate-space branch February 11, 2022 13:41

kibanamachine mentioned this pull request Feb 11, 2022

[8.1] [Fleet] Tell users when assets are installed in a different space (#125278) #125373

Merged

hop-dev mentioned this pull request Feb 14, 2022

[Fleet] Package assets should not break when installed within a space #74353

Closed

9 tasks

jen-huang added the v8.0.1 label Feb 14, 2022

jen-huang reviewed Feb 14, 2022

View reviewed changes

jen-huang added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 14, 2022

kibanamachine mentioned this pull request Feb 14, 2022

[8.0] [Fleet] Tell users when assets are installed in a different space (#125278) #125573

Merged

hop-dev mentioned this pull request Feb 16, 2022

[Fleet] Use existing hook for useKibana access in assets view #125809

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Tell users when assets are installed in a different space #125278

[Fleet] Tell users when assets are installed in a different space #125278

hop-dev commented Feb 10, 2022 •

edited

Loading

elasticmachine commented Feb 10, 2022

nchaulet left a comment

kibana-ci commented Feb 11, 2022

kibanamachine commented Feb 11, 2022

jen-huang Feb 14, 2022

hop-dev Feb 15, 2022

kibanamachine commented Feb 14, 2022

dikshachauhan-qasource commented Feb 28, 2022

		@@ -13,9 +13,10 @@ import { groupBy } from 'lodash';

		import type { ResolvedSimpleSavedObject } from 'src/core/public';

		import { useKibana } from '../../../../../../../../../../../src/plugins/kibana_react/public';

[Fleet] Tell users when assets are installed in a different space #125278

[Fleet] Tell users when assets are installed in a different space #125278

Conversation

hop-dev commented Feb 10, 2022 • edited Loading

Summary

Checklist

elasticmachine commented Feb 10, 2022

nchaulet left a comment

Choose a reason for hiding this comment

kibana-ci commented Feb 11, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Feb 11, 2022

💚 All backports created successfully

Questions ?

jen-huang Feb 14, 2022

Choose a reason for hiding this comment

hop-dev Feb 15, 2022

Choose a reason for hiding this comment

kibanamachine commented Feb 14, 2022

💚 All backports created successfully

Questions ?

dikshachauhan-qasource commented Feb 28, 2022

hop-dev commented Feb 10, 2022 •

edited

Loading