-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Tell users when assets are installed in a different space #125278
[Fleet] Tell users when assets are installed in a different space #125278
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @hop-dev |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…astic#125278) * Show new message when assets installed in separate space * move variable into useEffect (cherry picked from commit a81b11e)
@@ -13,9 +13,10 @@ import { groupBy } from 'lodash'; | |||
|
|||
import type { ResolvedSimpleSavedObject } from 'src/core/public'; | |||
|
|||
import { useKibana } from '../../../../../../../../../../../src/plugins/kibana_react/public'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just swung by this PR to backport it as a patch to 8.0 and noticed this, we have useStartServices
hook which encapsulates the plugin logic added by this PR so that can be use instead of traversing all the way to the kibana_react
plugin:
export function useStartServices(): FleetStartServices { |
I believe you'd just have to add spaces
to the FleetStartServices
interface. I think this would be a good candidate for a small PR 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing thanks! I'll get that done some time soon
…astic#125278) * Show new message when assets installed in separate space * move variable into useEffect (cherry picked from commit a81b11e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Hi @jen-huang We have validated this PR and found it working fine on 8.1.10 BC4.
Build details: Thanks |
Summary
Related to #74353
Previously, when an integration was installed in space 1, when viewing the assets in space 2 we would simply show "no assets found". We now display "This integration is installed, but no assets are available in this space".
Testing
I don't believe we have any cypress tests that create spaces yet so this seemed like more work than this bugfix deserves? I also believe the assets component has too many side effects for unit tests to be a good use of time here
Checklist
Delete any items that are not applicable to this PR.