Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click slower in timepicker #125264

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

flash1293
Copy link
Contributor

Fixes #124607

Opening both the from and to popover of the timepicker to check the current time doesn't work if the test goes too fast: elastic/eui#5619

This PR makes sure it's waiting a bit before opening the second one to make sure it's not getting stuck like in the linked issue. Once it's fixed on EUI side, this can be removed?

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 v8.0.1 labels Feb 10, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review February 10, 2022 17:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🆗

@flash1293 flash1293 merged commit ec7f2f3 into elastic:main Feb 10, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 10, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 10, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1
8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 10, 2022
(cherry picked from commit ec7f2f3)

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 10, 2022
(cherry picked from commit ec7f2f3)

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.1 v8.1.0 v8.2.0
Projects
None yet
5 participants