Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with the addition of filter editors #12321

Merged
merged 2 commits into from
Jun 22, 2017

Conversation

lukasolson
Copy link
Member

This PR updates the docs since the addition of filter editors.

Copy link

@alexfrancoeur alexfrancoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a minor comment for the operators but it's just a suggestion. The content and images look good.

particular value by selecting *is*, where a filter doesn't match a particular
value by selecting *is not*, where a field is present (*exists*), or where a
value for a field is within a range (*is between*). In addition, you can filter
where a field *is one of* a particular list of values.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this list be better represented as a table? Explicitly describing exactly how each operator works. It might be overkill, but at least we're not missing anything. There are 6 different operators. I added something similar here for the options available in Timelion

@lukasolson lukasolson merged commit 0e5ee35 into elastic:master Jun 22, 2017
lukasolson added a commit to lukasolson/kibana that referenced this pull request Jun 22, 2017
* Update docs with the addition of filter editors

* Move operators into a table
lukasolson added a commit to lukasolson/kibana that referenced this pull request Jun 22, 2017
* Update docs with the addition of filter editors

* Move operators into a table
@lukasolson
Copy link
Member Author

Backported to 5.5 (5.5.0) in 79c3ab1.
Backported to 6.0 (6.0.0-alpha3) in 4643586.

@lukasolson lukasolson deleted the filter-editor-docs branch March 27, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants