[Discover] Fix document explorer cell popover rendering #123194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Team:DataDiscovery
kertal
added
v8.1.0
release_note:skip
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
…8-fix-document-explorer-rendering
|
@elasticmachine merge upstream |
dimaanj
reviewed
Jan 26, 2022
src/plugins/discover/public/components/discover_grid/get_render_cell_value.tsx
Show resolved
Hide resolved
dimaanj
reviewed
Jan 26, 2022
src/plugins/discover/public/components/discover_grid/get_render_cell_value.tsx
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
dimaanj
approved these changes
Jan 27, 2022
majagrubic
approved these changes
Jan 27, 2022
| ) | ||
| .join(', '); | ||
| const pairs = highlights[key] ? highlightPairs : sourcePairs; | ||
| if (displayKey) { |
There was a problem hiding this comment.
I know I wrote this code, but omg is it horrible 😅
There was a problem hiding this comment.
so I've got good news for your, since I refactured the structure of the file, but did not touch the function's logic ... now technically: I wrote this code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the way values are rendered in the cell popover when fetching using the fields API (which is the default). With this PR the JSON viewer is just shown when rendering the
Documentcolumns, and for rendering top level objects (likeproductsof our ecommerce demo dataset) when fetching using_source. In all other cases the value the field formatter returns is displayed.Before:
After:
Fixes #118162
Checklist